-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEC]Auto FEC initial changes #2893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
approved these changes
Sep 2, 2023
/azpw.run Azure.sonic-swss |
@dgsudharsan please add me as reviewer |
ridahanif96
approved these changes
Sep 8, 2023
@prgeor to signoff |
ack |
@dgsudharsan can you update the PR description to point to the HLD? |
nazariig
suggested changes
Sep 27, 2023
nazariig
suggested changes
Sep 27, 2023
nazariig
approved these changes
Sep 29, 2023
prgeor
reviewed
Oct 3, 2023
prgeor
approved these changes
Oct 5, 2023
@prsunny LGTM. please merge. |
prsunny
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Initial Changes to support Auto FEC feature. Added support for mode "auto" in FEC
Why I did it
To implement auto FEC feature HLD: sonic-net/SONiC#1416
How I verified it
Added UT to verify. Additionally performed Manual testing.
Details if related