[Mellanox] Fix inconsistence in the shared headroom pool initialization

[stephenxs]

What I did

Fix inconsistent initialization of the shared headroom pool by setting a small size to indicate the shared headroom pool is enabled.

Signed-off-by: Stephen Sun stephens@nvidia.com

Why I did it

During initialization, if SHP is enabled

1. the buffer pool sizes, xoff have initialized to 0, which means SHP is disabled
2. but the buffer profiles already indicate SHP
3. later on the buffer pool sizes are updated with off being non-zero

In case the orchagent starts handling buffer configuration between 2 and 3, it is inconsistent between buffer pools and profiles, which fails Mellanox SAI sanity check.
To avoid it, it indicates SHP enabled by setting a very small buffer pool and SHP sizes

How I verified it

Details if related

[stephenxs]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stephenxs]

SRv6 test failed which is not relevant to my change.

    
        Args:
            table_name: The name of the table from which to fetch the keys.
            num_keys: The expected number of keys to retrieve from the table.
            polling_config: The parameters to use to poll the db.
            failure_message: The message to print if the call times out. This will only take effect
                if the PollingConfig is set to strict.
    
        Returns:
            The keys stored in the table. If no keys are found, then an empty List is returned.
        """
    
        def access_function():
            keys = self.get_keys(table_name)
            if wait_at_least_n_keys:
                return (len(keys) >= num_keys, keys)
            else:
                return (len(keys) == num_keys, keys)
    
        status, result = wait_for_result(
            access_function, self._disable_strict_polling(polling_config)
        )
    
        if not status:
            message = failure_message or (
                f"Unexpected number of keys: expected={num_keys}, received={len(result)} "
                f'({result}), table="{table_name}"'
            )
>           assert not polling_config.strict, message
E           AssertionError: Unexpected number of keys: expected=2, received=1 (('oid:0x3d000000000619',)), table="ASIC_STATE:SAI_OBJECT_TYPE_SRV6_SIDLIST"

[zhangyanzhao]

@bingwang-ms @neethajohn can you please help to review this PR?

[stephenxs]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

Cherry-pick PR to 202311: #3084

[bingwang-ms]

Hi @stephenxs, can you share the log pattern if the issue happened?

[stephenxs]

Hi @stephenxs, can you share the log pattern if the issue happened?

Hi @bingwang-ms
As the following

Feb 22 09:40:00.452958 sonic ERR syncd#SDK: :- sendApiResponse: api SAI_COMMON_API_CREATE failed in syncd mode: SAI_STATUS_INVALID_ATTRIBUTE_MAX
Feb 22 09:40:00.453055 sonic ERR syncd#SDK: :- processQuadEvent: attr: SAI_BUFFER_PROFILE_ATTR_XON_TH: 19456
Feb 22 09:40:00.453055 sonic ERR syncd#SDK: :- processQuadEvent: attr: SAI_BUFFER_PROFILE_ATTR_XOFF_TH: 33792
Feb 22 09:40:00.453132 sonic ERR syncd#SDK: :- processQuadEvent: attr: SAI_BUFFER_PROFILE_ATTR_RESERVED_BUFFER_SIZE: 19456
Feb 22 09:40:00.453132 sonic ERR syncd#SDK: :- processQuadEvent: attr: SAI_BUFFER_PROFILE_ATTR_POOL_ID: oid:0x18000000000a8f
Feb 22 09:40:00.453132 sonic ERR syncd#SDK: :- processQuadEvent: attr: SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE: SAI_BUFFER_PROFILE_THRESHOLD_MODE_DYNAMIC
Feb 22 09:40:00.453132 sonic ERR syncd#SDK: :- processQuadEvent: attr: SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH: 0
Feb 22 09:40:00.453221 sonic ERR swss#orchagent: :- create: create status: SAI_STATUS_INVALID_ATTRIBUTE_MAX
Feb 22 09:40:00.453236 sonic ERR swss#orchagent: :- processBufferProfile: Failed to create buffer profile pg_lossless_10000_5m_profile with type BUFFER_PROFILE_TABLE, rv:-131071
Feb 22 09:40:00.453236 sonic ERR swss#orchagent: :- handleSaiCreateStatus: Encountered failure in create operation, exiting orchagent, SAI API: SAI_API_BUFFER, status: SAI_STATUS_INVALID_ATTRIBUTE_MAX