Revamp module build script to make it work for 5.15 on Ubuntu 20.04 #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kperumalbfn
approved these changes
Jul 2, 2024
The current version of the script does not work at all when the host kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with the non-HWE kernel (version 5.4). Update the script to add support for building and loading the kernel modules for the 5.15 kernel, while keeping support for the non-HWE kernel. This is a cherry-pick of sonic-net/sonic-swss-common#720 Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com>
Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com>
saiarcot895
force-pushed
the
revamp-module-build-script
branch
from
6004d5a
to
e108d34
Compare
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jul 2, 2024
…onic-net#3212) * Revamp module build script to make it work for 5.15 on Ubuntu 20.04 The current version of the script does not work at all when the host kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with the non-HWE kernel (version 5.4). Update the script to add support for building and loading the kernel modules for the 5.15 kernel, while keeping support for the non-HWE kernel. This is a cherry-pick of sonic-net/sonic-swss-common#720 Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> * Remove libswsscommon dependencies from the script Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> --------- Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com>
|
Cherry-pick PR to 202405: #3214 |
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jul 2, 2024
…onic-net#3212) * Revamp module build script to make it work for 5.15 on Ubuntu 20.04 The current version of the script does not work at all when the host kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with the non-HWE kernel (version 5.4). Update the script to add support for building and loading the kernel modules for the 5.15 kernel, while keeping support for the non-HWE kernel. This is a cherry-pick of sonic-net/sonic-swss-common#720 Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> * Remove libswsscommon dependencies from the script Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> --------- Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com>
|
Cherry-pick PR to 202311: #3215 |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 2, 2024
…3212) * Revamp module build script to make it work for 5.15 on Ubuntu 20.04 The current version of the script does not work at all when the host kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with the non-HWE kernel (version 5.4). Update the script to add support for building and loading the kernel modules for the 5.15 kernel, while keeping support for the non-HWE kernel. This is a cherry-pick of sonic-net/sonic-swss-common#720 Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> * Remove libswsscommon dependencies from the script Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> --------- Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
|
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
2 similar comments
|
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
|
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
yejianquan
pushed a commit
to yejianquan/sonic-swss
that referenced
this pull request
Jul 8, 2024
…onic-net#3212) * Revamp module build script to make it work for 5.15 on Ubuntu 20.04 The current version of the script does not work at all when the host kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with the non-HWE kernel (version 5.4). Update the script to add support for building and loading the kernel modules for the 5.15 kernel, while keeping support for the non-HWE kernel. This is a cherry-pick of sonic-net/sonic-swss-common#720 Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> * Remove libswsscommon dependencies from the script Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> --------- Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com>
|
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
|
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
1 similar comment
|
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
yejianquan
added a commit
to yejianquan/sonic-swss
that referenced
this pull request
Jul 11, 2024
… 20.04 (sonic-net#3212)" This reverts commit 43ac585.
|
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 12, 2024
…3212) * Revamp module build script to make it work for 5.15 on Ubuntu 20.04 The current version of the script does not work at all when the host kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with the non-HWE kernel (version 5.4). Update the script to add support for building and loading the kernel modules for the 5.15 kernel, while keeping support for the non-HWE kernel. This is a cherry-pick of sonic-net/sonic-swss-common#720 Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> * Remove libswsscommon dependencies from the script Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com> --------- Signed-off-by: Saikrishna Arcot <saiarcot895@gmail.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The current version of the script does not work at all when the host kernel is Azure's 5.15 kernel on Ubuntu 20.04. It does seem to work with 5.11 and older.
Update the script to add support for building and loading the kernel modules for the 5.15 kernel, while keeping support for the non-HWE kernel.
In addition, use a separate updates/sonic directory for the kernel modules we compile, to make it clear they were compiled separately and don't come from the official kernel build packages.
Finally, add a warning if we're compiling a kernel module for a different version of the kernel than what is currently running.
This is a cherry-pick of sonic-net/sonic-swss-common#720
Why I did it
How I verified it
Details if related