Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orchagent]: Use priorities in orchagent #475

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

pavel-shirshov
Copy link
Contributor

What I did
I've added support of Selectable priorities for orchagent.
I've put following priorities to orchagent tables:

APP_PORT_TABLE_NAME = 45
APP_VLAN_TABLE_NAME = 42
APP_LAG_TABLE_NAME = 42
APP_VLAN_MEMBER_TABLE_NAME = 40
APP_LAG_MEMBER_TABLE_NAME = 40
APP_INTF_TABLE_NAME = 35
APP_NEIGH_TABLE_NAME= 30
APP_FDB_TABLE_NAME = 20
APP_ROUTE_TABLE_NAME = 5

All other orchagent run with lowest priority which is 0.

Why I did it
To prioritize messages inside of the orchagent message queue.

How I verified it
Build swss and run it

Details if related

@@ -16,8 +16,10 @@ extern sai_object_id_t gSwitchId;
extern PortsOrch* gPortsOrch;
extern CrmOrch * gCrmOrch;

const int fdborch_pri = 20;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fdborch_pri [](start = 10, length = 11)

It's inconvenient to scatter all the similar priority settings to many files.

@@ -36,6 +37,8 @@ const char config_db_key_delimiter = '|';
#define CONFIGDB_KEY_SEPARATOR "|"
#define DEFAULT_KEY_SEPARATOR ":"

const int default_orch_pri = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default_orch_pri [](start = 10, length = 16)

Move it to class local?

@pavel-shirshov
Copy link
Contributor Author

Hi Qi,

I'm going to refactor the whole orchdaemon class to make it readable including priorities. I didn't want to refactor in this PR, otherwise this PR would be stuck for another week.

@pavel-shirshov pavel-shirshov merged commit e849afe into sonic-net:master Apr 17, 2018
@pavel-shirshov pavel-shirshov deleted the pavelsh/swss_pri branch April 17, 2018 21:33
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…onic-net#475)

* Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD

Signed-off-by: Wenda Ni <wenni@microsoft.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
* Add default bridge id for bridge port id of type PORT in virtual switch

* Update recording

Virtual switch now supports Queue TYPE, so tests must be updated

* Add specific comparison logic for tunnel map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants