Fix tables handling race condition in buffermgr #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
lguohan
reviewed
Apr 23, 2018
| } | ||
| // In case of PORT table update, Buffer Manager is interested in speed update only | ||
| if (table_name == CFG_PORT_TABLE_NAME && fvField(i) == "speed") | ||
| { | ||
| // create/update profile for port | ||
| doSpeedUpdateTask(port, fvValue(i)); | ||
| task_status = doSpeedUpdateTask(port, fvValue(i)); |
There was a problem hiding this comment.
task_status is going to get overridden in the for loop.
There was a problem hiding this comment.
right... fixed
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
lguohan
pushed a commit
that referenced
this pull request
Apr 24, 2018
* Fix tables handling race condition in buffermgr Signed-off-by: Andriy Moroz <c_andriym@mellanox.com> * Fixed status lose in loop Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* [reboot script] add -h, -? and -x options Signed-off-by: Ying Xie <ying.xie@microsoft.com> * remove option -x * add some more help information for reboot script itself * change some wording/format
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
What I did
Fixed issue which may leave switch not fully configured when speed is applied before cable length table
Why I did it
Bug fix
How I verified it
Forced CABLE_LENGTH to be applied the last and checked switch completes config after all input i available.
Details if related