[flexcounter]: add support to change port/queue counter poll interval #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihui Han <sihan@microsoft.com>
|
depends on sonic-net/sonic-swss-common#200 |
|
retest this please |
| continue; | ||
| } | ||
|
|
||
| if (op == SET_COMMAND) |
There was a problem hiding this comment.
IFAIK if nothing is set, the default value of 1 second is used.
Then I think we also have to set the default back if the entry is deleted from DB.
There was a problem hiding this comment.
This entry only has set_command and no del command. We can always use set command to change the interval value.
|
retest this please |
1 similar comment
|
retest this please |
marian-pritsak
approved these changes
May 18, 2018
| continue; | ||
| } | ||
|
|
||
| if (op == SET_COMMAND) |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…all (sonic-net#499) fix wrong API type in internal_api_wait_for_response() add cmdline parse option "s" , otherwise syncd cannot be executed via -s option, system cannot be up with syncd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han sihan@microsoft.com
What I did
Add support to change port/queue counter poll interval
Why I did it
How I verified it
Tested on DUT.
Details if related