[Aclorch] fix Acl bind point type issue #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from Azure/sonic-swss master
qiluo-msft
approved these changes
Jun 21, 2018
qiluo-msft
reviewed
Jun 22, 2018
| bpoint_list.push_back(bind); | ||
| } | ||
|
|
||
| vector<int32_t> bpoint_list = { SAI_ACL_BIND_POINT_TYPE_PORT, SAI_ACL_BIND_POINT_TYPE_LAG }; |
There was a problem hiding this comment.
Also add SAI_ACL_BIND_POINT_TYPE_VLAN? #Closed
There was a problem hiding this comment.
yes, can add this, then we don't need to change the code in the future when deciding to support VLAN.
qiluo-msft
approved these changes
Jun 25, 2018
qiluo-msft
requested changes
Jun 25, 2018
There was a problem hiding this comment.
Offline discussed with @lguohan, SONiC should not use SAI_ACL_BIND_POINT_TYPE_VLAN because it is not a supported feature. So let's remove the latest commit from this PR.
Sorry for the late comment.
This reverts commit e026cc1.
|
well, let's remove it. |
qiluo-msft
approved these changes
Jun 26, 2018
|
Offline discussed with @prsunny. Our goal is:
However one ASIC SAI implementation is not ready right now (Mellanox SAI is ok). The ETA for unblocking is 7/4. |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
- add redis_dummy_remove_route_entry() for meta_sai_remove_route_entry() calls, which is the same logic as create/set - add NULL pointer check and add meta_sai_remove_route_entry() calls which will remove meta data after remove entries. The logic is the same as create/set - syncd add bulkremove option for processEvent() to select processBulkEvent() - together with this , there should be a consumer_table_pops.lua script changes to handle bulkremove in sonic_swss_common sonic-net/sonic-swss-common#306 - after these changes , when we call bulk_create and bulk_remove, the meta data is cleared and we can bulk_create again, otherwise it raise error entry already exists. Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Change the previous way to add ACL table bind point type. previously it will check all the port type in the ACL table to decide which type of bind point will be added to this table. Now by default, an ACL table will support both PORT and LAG bind point, no need to go through all the port and check the port type.
Why I did it
The original way will cause an issue when ACL member LAG is not configured yet but the table already created, then the LAG bind point will not be added and result in failure later when the LAG configured and bind the ACL table to this LAG.
How I verified it
Run ACL/Everflow and CRM test on the testbed.
Details if related