Postpone QueueMap initialization until activation of the counters #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihuihan88
reviewed
Jun 25, 2018
| @@ -70,6 +70,10 @@ void FlexCounterOrch::doTask(Consumer &consumer) | |||
| } | |||
| else if(field == FLEX_COUNTER_STATUS_FIELD) | |||
| { | |||
| // Currently the counters are disabled by default | |||
| // The queue maps will be generated as soon as counters are enabled | |||
| gPortsOrch->generateQueueMap(); | |||
There was a problem hiding this comment.
Is the map generated after queue counters are enabled or all the counters are enabled?
There was a problem hiding this comment.
The map is generated after activation of the flex counters. As I understand the maps are related to port queues. So they will be used with queue counters.
lguohan
reviewed
Jun 25, 2018
| @@ -1817,61 +1817,6 @@ void PortsOrch::initializeQueues(Port &port) | |||
| } | |||
|
|
|||
| SWSS_LOG_INFO("Get queues for port %s", port.m_alias.c_str()); | |||
|
|
|||
| /* Create the Queue map in the Counter DB */ | |||
| /* Add stat counters to flex_counter */ | |||
There was a problem hiding this comment.
do we need queue map for applying qos configuration?
There was a problem hiding this comment.
No. We use only Port::m_queue_ids vector. We use the maps only for:
- swss: pfc handler
- swss: countercheckorch
- queuestat
- snmp
- pfcwd utility
lguohan
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I postponed generation of the QueueMaps until the counters are activated.
Why I did it
We don't need QueueMaps until the counters are active
How I verified it
Build an image and run on DUT
Details if related