[WR]: Add reconciliation logic for teamsyncd #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jipanyang
reviewed
Dec 7, 2018
qiluo-msft
reviewed
Dec 7, 2018
qiluo-msft
reviewed
Dec 7, 2018
qiluo-msft
reviewed
Dec 7, 2018
qiluo-msft
reviewed
Dec 7, 2018
qiluo-msft
approved these changes
Dec 7, 2018
jipanyang
reviewed
Dec 8, 2018
There was a problem hiding this comment.
Could you update schema for timer too: https://github.com/Azure/sonic-swss/blob/master/doc/swss-schema.md#warm_restart ?
|
The schema was added |
jipanyang
approved these changes
Dec 13, 2018
jipanyang
reviewed
Dec 17, 2018
| @@ -11,19 +11,23 @@ | |||
| #include "netmsg.h" | |||
| #include <team.h> | |||
|
|
|||
| // seconds | |||
| const uint32_t DEFAULT_WR_PENDING_TIMEOUT = 70; | |||
There was a problem hiding this comment.
Would like to understand the logic behind this default value of 70 seconds here.
With lacp slow mode, 30 second interval * 3 times = 90 seconds, all the teamd related processing has to be within that range from teamd shutdown to the lacp connection reestablished.
During warm reboot, are you expecting it will take about 20 seconds from teamd shutdown to teamd restarted, then from teamd started to lacp connected, it will take x*10 seconds?
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…net#725) Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Changes include SAI support for voq neighbor. VOQ neighbor requires an additional attribute to set the encap index. For local neighbors the encap index iis assigned by SAI, if not imposed. For remote neighbors, the encap index is required to be supplised by the upper layer. The changes validate these conditions for remote neighbors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added reconciliation logic for teamsyncd.
Why I did it
To avoid sending wrong updates to swss from teamsyncd.
How I verified it
Install changes to teamd docker. Restart dut in cold mode, then restart dut in wr mode.
Details if related