Fix vlan incremental config and add vs test cases #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
|
can you add more comments on what problem it is trying to solve here? |
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
qiluo-msft
reviewed
Mar 20, 2019
cfgmgr/vlanmgr.cpp
Outdated
| * Don't program vlan again if state is already set. | ||
| * will hit this for docker warm restart. | ||
| * Just set the internal data structure and remove the request. | ||
| * If state is already set for this vlan, but it doesn't exit in m_vlans set, |
There was a problem hiding this comment.
exit [](start = 69, length = 4)
typo? #Closed
|
"vconfig" missing in the Jenkins unit test environment, it is requirement for the tagged vlan test. |
|
vconfig is installed. |
qiluo-msft
approved these changes
Apr 24, 2019
jipanyang
force-pushed
the
vlan_incremental
branch
2 times, most recently
from
eac5357 to
b4f8d1a
Compare
jipanyang
force-pushed
the
vlan_incremental
branch
from
b4f8d1a to
0b9d0bd
Compare
|
@qiluo-msft as discussed offline, please help merge the change if no further comment. thanks. |
|
Resolve conflict? |
|
@qiluo-msft conflict resolved. |
|
@lguohan Do you have more concern? |
lguohan
approved these changes
Jun 4, 2019
yxieca
pushed a commit
that referenced
this pull request
Jul 19, 2019
* Fix vlan incremental config and add vs test cases Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
… 7.1" (sonic-net#799) Signed-off-by: kcudnik <kcudnik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jipan Yang jipan.yang@alibaba-inc.com
What I did
Fix vlan incremental config update.
Why I did it
How I verified it
VS.
Details if related