-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vxlanmgrd]: Add vxlanmgrd #807
Conversation
vxlanmgrd is responsible for vxlan configuration in Linux It creates vxlan interface for every vxlan entry in Config DB Signed-off-by: Ze Gan <zegan@microsoft.com>
1. Segment fault 2. Delete vxlan fail Signed-off-by: Ze Gan <zegan@microsoft.com>
Combine vxlan_tunnel and vnet:vni to be a vxlan Signed-off-by: Ze Gan <zegan@microsoft.com>
Signed-off-by: Ze Gan <zegan@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must have the changes in VxlanOrch.h (Line 140 and 201) to have the separator as :
instead of |
…an tunnel map Signed-off-by: Ze Gan <zegan@microsoft.com>
Vxlanmgr rebase
…_DETACH_BRIDGE_FROM_VNET
retest this please |
If linux commands fail, don't remove this event. print the error log and try it again. Signed-off-by: Ze Gan <zegan@microsoft.com>
- Change config db polling operation to cache - Use VxlanInfo struct to replace stl map
// Because the vxlan has been create, so this message is to update | ||
// the information of vxlan. | ||
// This program just delete the old vxlan and create a new one | ||
// according to this message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an LOG_INFO message here. This doesn't looks to be a valid scenario. We get a delete followed by a create.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a scenario that the user want to update the vxlan tunnel or vni to this VNET.
We can delete the old one and create a new one to implement this scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't have such a scenario
Signed-off-by: Ze Gan <zegan@microsoft.com>
…onic-net#807) - Update shebang in gbsyncd_startup.py to `#!/usr/bin/env python3`, as the previous `#!/usr/bin/python` doesn't work with our Python 3 installation - Make gbsyncd_startup.py executable
vxlanmgrd is responsible for vxlan configuration in Linux
It creates vxlan interface for every vxlan entry in Config DB
Signed-off-by: Ze Gan zegan@microsoft.com