Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vxlanmgrd]: Add vxlanmgrd #807

Merged
merged 13 commits into from
Apr 23, 2019
Merged

[vxlanmgrd]: Add vxlanmgrd #807

merged 13 commits into from
Apr 23, 2019

Conversation

Pterosaur
Copy link
Contributor

vxlanmgrd is responsible for vxlan configuration in Linux
It creates vxlan interface for every vxlan entry in Config DB

Signed-off-by: Ze Gan zegan@microsoft.com

vxlanmgrd is responsible for vxlan configuration in Linux
It creates vxlan interface for every vxlan entry in Config DB

Signed-off-by: Ze Gan <zegan@microsoft.com>
1. Segment fault
2. Delete vxlan fail

Signed-off-by: Ze Gan <zegan@microsoft.com>
Combine vxlan_tunnel and vnet:vni to be a vxlan

Signed-off-by: Ze Gan <zegan@microsoft.com>
Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must have the changes in VxlanOrch.h (Line 140 and 201) to have the separator as : instead of |

orchagent/orchdaemon.cpp Outdated Show resolved Hide resolved
orchagent/orchdaemon.cpp Outdated Show resolved Hide resolved
…an tunnel map

Signed-off-by: Ze Gan <zegan@microsoft.com>
@prsunny prsunny closed this Apr 11, 2019
@prsunny prsunny reopened this Apr 11, 2019
@prsunny
Copy link
Collaborator

prsunny commented Apr 11, 2019

retest this please

@sonic-net sonic-net deleted a comment from Pterosaur Apr 11, 2019
If linux commands fail, don't remove this event. print the error log and try it again.

Signed-off-by: Ze Gan <zegan@microsoft.com>
cfgmgr/vxlanmgr.h Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.h Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.h Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.h Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.h Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vxlanmgr.cpp Show resolved Hide resolved
// Because the vxlan has been create, so this message is to update
// the information of vxlan.
// This program just delete the old vxlan and create a new one
// according to this message.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an LOG_INFO message here. This doesn't looks to be a valid scenario. We get a delete followed by a create.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a scenario that the user want to update the vxlan tunnel or vni to this VNET.
We can delete the old one and create a new one to implement this scenario.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't have such a scenario

cfgmgr/vxlanmgr.cpp Outdated Show resolved Hide resolved
Signed-off-by: Ze Gan <zegan@microsoft.com>
@prsunny prsunny merged commit d612d5e into sonic-net:master Apr 23, 2019
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
…onic-net#807)

- Update shebang in gbsyncd_startup.py to `#!/usr/bin/env python3`, as the previous `#!/usr/bin/python` doesn't work with our Python 3 installation
- Make gbsyncd_startup.py executable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants