[portsorch]: add support to set mac-address learning attribute on bridge-port #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from origin
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
shine4chen
changed the title
|
learning mode can also be supported in lag, but it looks like the code here does not consider that scenario. |
Lag is also supported, please see the function PortsOrch::doLagTask(Consumer &consumer). Thinks. |
|
Learning mode has been supported in lag, but the corresponding vs-test requires lag-name-oid-map. PR#885 will provide support for lag-name-oid-map, so the vs-test code can only be provided after its modification is completed. |
stcheng
previously requested changes
Jun 4, 2019
Signed-off-by: leo.li <leo.li@nephosinc.com>
|
The vstest has been added, please review. Thanks! |
added 2 commits
June 17, 2019 00:51
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
…/sonic-swss into bridge-port-mac-learn
|
@stcheng we has refined code according to your suggestion. Pls review thanks. |
Signed-off-by: leo.li <leo.li@nephosinc.com>
lisahnguyen
reviewed
Aug 29, 2019
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
lisahnguyen
approved these changes
Sep 18, 2019
gitsabari
approved these changes
Sep 18, 2019
|
retest this please |
shine4chen
force-pushed
the
bridge-port-mac-learn
branch
2 times, most recently
from
32416e3
to
53a3f1e
Compare
shine4chen
force-pushed
the
bridge-port-mac-learn
branch
from
53a3f1e
to
92100be
Compare
lguohan
approved these changes
Nov 12, 2019
lguohan
approved these changes
Nov 12, 2019
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Introduce `gbsyncdmgrd`, which will be responsible for spawning and watching all gearbox syncd processes. `gbsyncdmgrd` is intended to supplant `gbsyncd_startup.py`. But until all references have been updated, we keep both, and I have added a deprecation warning to `gbsyncd_startup.py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
add support to set mac-address learning attribute on bridge-port
Why I did it
Mclag feature need this. And it is common attribute for bridge-port.
How I verified it
compile and test on nephos lab
Details if related