-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mclag]:add mclagsyncd #811
Conversation
pull from origin
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the comments
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my review comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking care of review comments
Signed-off-by: shine.chen <shine.chen@mediatek.com>
retest this please. |
Signed-off-by: shine.chen <shine.chen@mediatek.com>
Signed-off-by: shine.chen <shine.chen@mediatek.com>
…into mclagsyncd
retest this please |
I saw binary in the pr. please remove the binary. |
Signed-off-by: shine.chen <shine.chen@mediatek.com>
@lguohan Thanks, done |
Signed-off-by: shine.chen <shine.chen@mediatek.com>
retest this please |
retest this please |
1 similar comment
retest this please |
Signed-off-by: shine.chen <shine.chen@mediatek.com>
b44975f
@stcheng @rlhui @gitsabari @lisahnguyen I resolved some conflict and system automatically dismiss your approve. Would you please help to review and approve it again ? |
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
What I did
add mclagsyncd
Why I did it
accomplish it according to MCLAG HLD document
How I verified it
test it on nephos lab
Details if related
Please refer #sonic-net/SONiC#325