Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mclag]:add mclagsyncd #811

Merged
merged 14 commits into from
Mar 22, 2020
Merged

[mclag]:add mclagsyncd #811

merged 14 commits into from
Mar 22, 2020

Conversation

shine4chen
Copy link
Contributor

What I did
add mclagsyncd

Why I did it
accomplish it according to MCLAG HLD document

How I verified it
test it on nephos lab

Details if related
Please refer #sonic-net/SONiC#325

shine4chen and others added 2 commits February 13, 2019 17:59
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
@shine4chen shine4chen changed the title add mclagsyncd for mclag feature [mclag]:add mclagsyncd Mar 11, 2019
shine.chen added 2 commits March 18, 2019 19:58
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
@lguohan lguohan requested a review from rlhui August 1, 2019 17:56
mclagsyncd/mclaglink.cpp Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.h Outdated Show resolved Hide resolved
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments

mclagsyncd/mclaglink.h Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.h Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.cpp Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.h Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.cpp Outdated Show resolved Hide resolved
mclagsyncd/mclaglink.cpp Outdated Show resolved Hide resolved
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
lisahnguyen
lisahnguyen previously approved these changes Sep 18, 2019
Copy link

@lisahnguyen lisahnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my review comment.

gitsabari
gitsabari previously approved these changes Sep 18, 2019
Copy link
Contributor

@gitsabari gitsabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of review comments

Signed-off-by: shine.chen <shine.chen@mediatek.com>
@shine4chen
Copy link
Contributor Author

retest this please.

Signed-off-by: shine.chen <shine.chen@mediatek.com>
@shine4chen
Copy link
Contributor Author

retest this please

@lguohan
Copy link
Contributor

lguohan commented Nov 12, 2019

I saw binary in the pr. please remove the binary.

Signed-off-by: shine.chen <shine.chen@mediatek.com>
@shine4chen
Copy link
Contributor Author

@lguohan Thanks, done

Signed-off-by: shine.chen <shine.chen@mediatek.com>
rlhui
rlhui previously approved these changes Nov 22, 2019
@shine4chen
Copy link
Contributor Author

retest this please

stcheng
stcheng previously approved these changes Nov 26, 2019
@shine4chen
Copy link
Contributor Author

retest this please

1 similar comment
@shine4chen
Copy link
Contributor Author

retest this please

Signed-off-by: shine.chen <shine.chen@mediatek.com>
@shine4chen
Copy link
Contributor Author

@stcheng @rlhui @gitsabari @lisahnguyen I resolved some conflict and system automatically dismiss your approve. Would you please help to review and approve it again ?

@shine4chen shine4chen requested a review from rlhui February 4, 2020 09:17
@shine4chen shine4chen requested review from rlhui and removed request for rlhui February 12, 2020 03:21
@rlhui rlhui merged commit 0de72da into sonic-net:master Mar 22, 2020
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants