swss-orchagent: add new orch for vnet routes/tunnel routes tables in CONFIG_DB #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weixchen1215
changed the title
|
retest this please |
|
Depends on this PR |
prsunny
requested changes
May 23, 2019
orchagent/vnetorch.cpp
Outdated
| auto t = it->second; | ||
| const std::string & op = kfvOp(t); | ||
|
|
||
| if (op == SET_COMMAND) |
There was a problem hiding this comment.
You can pass the op and handle in a single function to avoid code duplication
tests/test_vnet.py
Outdated
| attrs, | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
You can remove this extra line
orchagent/vnetorch.h
Outdated
| @@ -10,6 +10,8 @@ | |||
| #include "request_parser.h" | |||
| #include "ipaddresses.h" | |||
|
|
|||
There was a problem hiding this comment.
Line skip is not required. You can add it along with other includes
…uplication of code Signed-off-by: weixi.chen@microsoft.com
|
retest this please |
prsunny
approved these changes
May 28, 2019
|
retest this please |
1 similar comment
|
retest this please |
stcheng
reviewed
Jun 5, 2019
orchagent/vnetorch.cpp
Outdated
| { | ||
| bool task_result = false; | ||
| auto t = it->second; | ||
| const std::string & op = kfvOp(t); |
There was a problem hiding this comment.
could you remove the std:: in the cpp file?
There was a problem hiding this comment.
remove them all for my changes in this .cpp files
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Will list all RIDs that are not present in rid2vid map right after warm boot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Weixi Chen Weixi.Chen@microsoft.com
What I did
Why I did it
Static vnet routes provisioned in sonic are not persistence. Switch reboot leads to the loss of static routes. Tables in CONFIG_DB will be persistent if a config save is manually performed.
How I verified it
run vs test: sudo pytest test_vnet.py -s -v --dvsname=vs
output:
/usr/local/lib/python2.7/dist-packages/requests/init.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
warnings.warn(warning, RequestsDependencyWarning)
======================================================================== test session starts ========================================================================
platform linux2 -- Python 2.7.12, pytest-3.3.0, py-1.8.0, pluggy-0.6.0 -- /usr/bin/python
cachedir: .cache
rootdir: /home/weixi-vs/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 3 items
test_vnet.py::TestVnetOrch::test_vnet_orch_2 PASSED [ 33%]
test_vnet.py::TestVnetOrch::test_vnet_orch_3 PASSED [ 66%]
test_vnet.py::TestVnetOrch::test_vnet_orch_1 PASSED [100%]
==================================================================== 3 passed in 174.11 seconds =====================================================================