[vnetorch]: Fix tunnel route removal flow for bitmap VNET #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
|
retest this please |
marian-pritsak
approved these changes
May 29, 2019
prsunny
approved these changes
Jun 7, 2019
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com
What I did
Fixed tunnel route removal flow for bitmap VNET by adding remove logic for newly added
meta tunnelentry.Why I did it
Some time ago, when
encapflow was changed for bitmap VNET, onlycreateflow was added for newmeta tunnelentry andremovewas missed. As a result if remove tunnel routemeta tunnelentry still exists in HW, which is incorrect.How I verified it
Ran ansible and VS tests.
Details if related
N/A