Ignore neighbor entry with BCAST MAC, check SAI status exists #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
reviewed
May 28, 2019
yxieca
reviewed
May 28, 2019
yxieca
approved these changes
May 28, 2019
yxieca
pushed a commit
that referenced
this pull request
May 29, 2019
* Ignore neighbor entry with BCAST MAC, check SAI status exists * Addressed review comment
lguohan
pushed a commit
that referenced
this pull request
May 29, 2019
* Ignore neighbor entry with BCAST MAC, check SAI status exists * Addressed review comment
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…#914) * Changes to make lldp show command for multi-npu platforms. We will display only front-panel port information. * Address Review Comments. * Added Comment * Fix LGTM error * Address Review Comments
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In certain cases, we get neighbor entries with BCAST MAC. This can be safely ignored from programming the hardware
Why I did it
Directed bcast entries are added as part of Interface IP address creation. The neighbor update is redundant.
How I verified it
Configure neighbor entry with BCAST mac.
Details if related