Fix typo in orchagent_restart_check from fasle to false. #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
|
retest this please |
|
retest this please |
3 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
|
Retest this please |
1 similar comment
|
Retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…onic-net#923) Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jipan Yang jipan.yang@alibaba-inc.com
What I did
Fix typo.
Why I did it
Though the "fasle" typos don't affect current warm_restart_check functions duo to the fact that both noFreeze and skipPendingTaskCheck are being checked against "true" value, they pose some potential risk for future update.
https://github.com/Azure/sonic-swss/blob/master/orchagent/switchorch.cpp#L175
https://github.com/Azure/sonic-swss/blob/master/orchagent/switchorch.cpp#L179
How I verified it
VS test.
Details if related