stop looping on failure to read from syncd #944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) if SAI API fails to fetchport info, break from querying for other ports, as most likely they fail too. 2) crmorch, has a bug of two objects claiming ownership of memory, which leads to double delete during exit. Let the base class own and, crmorch does not own.
renukamanavalan
requested review from
yxieca,
lguohan,
marian-pritsak and
qiluo-msft
prsunny
reviewed
Jun 19, 2019
qiluo-msft
reviewed
Jun 19, 2019
…ster. The other change (drop redundant timer set) is required in master too. So do it there and cherry pick into March.
renukamanavalan
changed the title
|
retest this please |
|
This may be not needed. Because w/o syncd, orchagent is of no value. So saving time in a loop or not, does not make any difference. The TSG for syncd down is to restart swss, which will restart orchagent. Plan to drop this PR. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
When restarting services, don't attempt to restart a service if it is disabled/masked or the `systemctl restart` command will fail, causing the calling command (e.g., `config load`, `config reload`, `config load_minigraph`) to error out.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the base class own and, crmorch does not own.
What I did
Why I did it
How I verified it
Details if related