Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create unit tests for CLI commands and integrate into build checks #120

Open
jleveque opened this issue Oct 5, 2017 · 1 comment
Open

Create unit tests for CLI commands and integrate into build checks #120

jleveque opened this issue Oct 5, 2017 · 1 comment
Labels
Enhancement

Comments

@jleveque
Copy link
Contributor

jleveque commented Oct 5, 2017

No description provided.

@stcheng
Copy link
Contributor

stcheng commented Oct 6, 2017

👏👏👏

vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this issue Jul 23, 2021
@bratashX @jleveque
[thermalctld] [psud] [chassisd] Fix crash with undefined environment …
b90ddda 
…variable (sonic-net#120)

When  `PSUD_UNIT_TESTING` and  `THERMALCTLD_UNIT_TESTING` variables don`t set we have the next problems:
```
 psud Traceback (most recent call last):
 psud File "/usr/local/bin/psud", line 21, in <module>
 psud if os.environ["PSUD_UNIT_TESTING"] == "1":
 psud File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
 psud raise KeyError(key)
 psud KeyError: 'PSUD_UNIT_TESTING'
```

```
 thermalctld Traceback (most recent call last):
 thermalctld File "/usr/local/bin/thermalctld", line 19, in <module>
 thermalctld if os.environ["THERMALCTLD_UNIT_TESTING"] == "1":
 thermalctld File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
 thermalctld raise KeyError(key)
 thermalctld KeyError: 'THERMALCTLD_UNIT_TESTING'
```

Also fixed the same issue in `chassisd`.

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this issue Apr 28, 2022
@lguohan @abdosi
[Mellanox]Integrate hw-mgmt 7.0000.3012 and advance the linux kernel …
9eb3a1b 
…(#4193)

* [Mellanox]Integrate hw-mgmt 7.0000.3012

* [sonic-linux-kernel]Advance the submodule head

Advance the sonic-linux-kernel

[sFlow]: Patch to fix skb_over_panic in psample driver (sonic-net#120)
Added support in the kernel for fullcone 3-tuple unique nat. (sonic-net#100)
Adding support to compile ARM architecture (sonic-net#102)
[ixgbe] Support bcm54616s external phy in ixgbe (sonic-net#122)
Fix i2c ISMT DMA buffer alignment issue (sonic-net#123)
[mellanox]: Add SN4700 patches. (sonic-net#126)
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this issue Sep 15, 2023
@jleveque
[setup.py] Update dependenices (sonic-net#120)
7255d3a 
Update dependencies in setup.py to align with current needs. This allows for implicit installation of dependencies at build and run time, and prevents the need to explicitly install these packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stcheng @jleveque