Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show/config]: combine feature and container feature cli #1015

Merged
merged 8 commits into from
Aug 3, 2020

Commits on Aug 3, 2020

  1. [show/config]: combine feature and container feature cli

    merge container feature cli into feature cli
    
    config command:
    ```
    admin@vlab-01:~$ sudo config feature
    Usage: config feature [OPTIONS] COMMAND [ARGS]...
    
      Modify configuration of features
    
    Options:
      -?, -h, --help  Show this message and exit.
    
    Commands:
      autorestart  Configure autorestart status for a feature
      state        Configure status of feature
    ```
    
    show command:
    ```
    admin@vlab-01:~$ show feature
    Usage: show feature [OPTIONS] COMMAND [ARGS]...
    
      Show feature status
    
    Options:
      -?, -h, --help  Show this message and exit.
    
    Commands:
      autorestart  Show auto-restart status for a feature
      status       Show feature status
    ```
    
    output:
    
    ```
    admin@vlab-01:~$ show feature status
    Feature     Status    AutoRestart
    ----------  --------  -------------
    lldp        enabled   enabled
    pmon        enabled   enabled
    sflow       disabled  enabled
    database    enabled   disabled
    restapi     disabled  enabled
    telemetry   enabled   enabled
    snmp        enabled   enabled
    bgp         enabled   enabled
    radv        enabled   enabled
    dhcp_relay  enabled   enabled
    nat         enabled   enabled
    teamd       enabled   enabled
    syncd       enabled   enabled
    swss        enabled   enabled
    admin@vlab-01:~$ show feature autorestart
    Feature     AutoRestart
    ----------  -------------
    lldp        enabled
    pmon        enabled
    sflow       enabled
    database    disabled
    restapi     enabled
    telemetry   enabled
    snmp        enabled
    bgp         enabled
    radv        enabled
    dhcp_relay  enabled
    nat         enabled
    teamd       enabled
    syncd       enabled
    swss        enabled
    ```
    
    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    lguohan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    37b4acd View commit details
    Browse the repository at this point in the history
  2. rename status to state

    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    lguohan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    20967a5 View commit details
    Browse the repository at this point in the history
  3. fix comments

    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    lguohan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    abcc53e View commit details
    Browse the repository at this point in the history
  4. add unit test

    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    lguohan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    b13931b View commit details
    Browse the repository at this point in the history
  5. address lgtm warning

    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    lguohan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    64d3db3 View commit details
    Browse the repository at this point in the history
  6. address comments

    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    lguohan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    51a77b4 View commit details
    Browse the repository at this point in the history
  7. move code int def cli and config

    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    lguohan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    89c4cb1 View commit details
    Browse the repository at this point in the history
  8. change asic_type to global

    Signed-off-by: Guohan Lu <lguohan@gmail.com>
    lguohan committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    65d54bb View commit details
    Browse the repository at this point in the history