[acl-loader] Add acl-loader utility. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oleksandrivantsiv
commented
Sep 27, 2017
oleksandrivantsiv
commented
- Add acl-loader implementation based on translate-acl utility.
- Add shortcuts to show command.
- Add shortcuts to config command.
oleksandrivantsiv
force-pushed
the
acl-loader
branch
from
9f981ab
to
ee8ea20
Compare
oleksandrivantsiv
force-pushed
the
acl-loader
branch
from
7091d4f
to
6a99e07
Compare
taoyl-ms
approved these changes
Oct 11, 2017
taoyl-ms
reviewed
Oct 12, 2017
| @click.argument('table_name', type=click.STRING, required=False) | ||
| @click.argument('rule_id', type=click.STRING, required=False) | ||
| @click.pass_context | ||
| def rule(ctx, table_name, rule_id): |
There was a problem hiding this comment.
Can we add an option to specify max_priority explicitly instead of using default value?
There was a problem hiding this comment.
Do you want to make it mandatory? Or we still should use a default value if priority is not provided by user?
There was a problem hiding this comment.
It should be optional and we should fall back to default value if not specified by user.
|
resolve the conflicts |
oleksandrivantsiv
force-pushed
the
acl-loader
branch
from
6a99e07
to
6506b02
Compare
|
@stcheng conflict resolved |
- Add acl-loader implementation based on translate-acl utility. - Add shortcuts to show command. - Add shortcuts to config command.
oleksandrivantsiv
force-pushed
the
acl-loader
branch
from
6506b02
to
bf6e2a2
Compare
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
e030133 [thermalctld] Print exception using repr(e) to get more information (sonic-net#103) (sonic-net#109)
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Currently, we are building both Python 2 and Python 3 versions of sonic-platform-common. However, we are currently not creating a Python 3 version of sonic-config-engine, so the build breaks. As I intend to remove this dependency in the near future anyway, I am removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.