[201911][show] Fix 'show int neigh expected' #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`show int neighbor expected` only show one member interface for portchannel with multiple member interfaces. This is because `device2interface_dict` only stores mapping from one device to one port. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
Retest this please |
|
is this the downport of pr #1162 |
lguohan
approved these changes
Oct 27, 2020
|
no it cannot. |
|
retest this please |
|
Retest this please |
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
|
@jleveque , is 201911 unit test broken now? |
Unfortunately, yes, the check build is broken for 201911 becuase it is shared with master, and it has been changed to build and test as a wheel in master, but it is still built as a Debian package in 201911. |
jleveque
changed the title
|
the code has no issue. unit test is not working for 201911 branch. |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
c0df635 (HEAD -> 201911, origin/201911) Updates to bgp config and show commands with BGP_INTERNAL_NEIGHBOR table (sonic-net#1224) (sonic-net#1237) d683bb4 [CLI][show][platform] Added ASIC count in the output. (sonic-net#1185) (sonic-net#1227) 4585be1 [show] Fix 'show int neigh expected' (sonic-net#1189) 29e4469 [201911][fwutil]: Use logger from sonic-py-common (sonic-net#1190) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show int neighbor expectedonly show one member interface forportchannel with multiple member interfaces. This is because
device2interface_dictonly stores mapping from one device to oneport.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)