Remove explicit dependency on swsssdk #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Oct 6, 2017
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Parse quagga output without knowledge about hostname, so robust against hostname changes or mismatch (sonic-net#124) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…ic-net#124) sonic-platform-base: Changes to enhance module_base.py and chassis_base.py for modular chassis HLD: sonic-net/SONiC#646 - Enhance ModuleBase with new APIs to repesent pluggable cards in a voq-chassis. - Enhance ChassisBase with new APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swsssdk package is installed as a wheel. If we compile sonic-utilities as a wheel, it will locate the swsssdk package dependency. However, if we compile sonic-utilities as a Debian package, it will look for a swsssdk Debian package, fail to find it, and the installation will fail.
However, building as a wheel introduced a few unexpected changes, such as installing the scripts in /usr/local/bin vs. /usr/bin, as well as the lack of ability to copy files outside of python package directory (i.e., bash_completion files to /etc/bash_completion.d/).
For now, we remove this explicit dependency in order to revert back to building sonic-utilities as a Debian package until we find a better solution, as we should specify all dependencies to ensure proper builds in case something goes wrong with the swsssdk installation. Ultimately, it would be great if we could build Debian packages that depend on wheels and vice-versa.