Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic fix - replace hard-coded fast-reboot with REBOOT_TYPE variable #1254

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

vaibhavhd
Copy link
Contributor

- What I did
Fixes sonic-net/sonic-buildimage#5980

One of the logging statements during warm-reboot incorrectly prints fast-reboot.

- How I did it
Remove hard-coded fast-reboot with REBOOT_TYPE variable

- How to verify it
Modified the script in device, and tested that logging is corrected:

- Previous command output (if the output of a command-line utility has changed)

admin@sonic-device:~$ sudo warm-reboot -vvv
Thu 19 Nov 2020 08:23:46 PM UTC Pausing orchagent ...
Thu 19 Nov 2020 08:23:47 PM UTC Collecting logs to check ssd health before fast-reboot...
...
...
Thu 19 Nov 2020 08:24:13 PM UTC Enabling Watchdog before warm-reboot

- New command output (if the output of a command-line utility has changed)

admin@sonic-device:~$ sudo warm-reboot -vvv
Thu 19 Nov 2020 10:39:04 PM UTC Pausing orchagent ...
Thu 19 Nov 2020 10:39:05 PM UTC Collecting logs to check ssd health before warm-reboot...
...
...
Thu 19 Nov 2020 10:39:25 PM UTC Enabling Watchdog before warm-reboot

@vaibhavhd vaibhavhd merged commit 05c8e33 into sonic-net:master Nov 20, 2020
@vaibhavhd vaibhavhd deleted the log-warm-reboot branch November 20, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[logging] SSD health check print fast-reboot when warm-reboot is issued
2 participants