Advertise ipv6 link local address #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging edc2196 into 5cff775 - view on LGTM.com new alerts:
|
prsunny
reviewed
Feb 5, 2021
prsunny
reviewed
Feb 5, 2021
scripts/neighbor_advertiser
Outdated
| ip = IPNetwork(keys[1]) | ||
| if str(ip.ip).startswith("fe80"): | ||
| ipv6_addr.append(str(ip.ip)) | ||
| ipv6_prefix.append(ip.prefixlen) |
There was a problem hiding this comment.
For link-local, the prefix length should be always set to 128.
|
This pull request introduces 1 alert when merging e2ecf4c into a6e322a - view on LGTM.com new alerts:
|
prsunny
approved these changes
Feb 5, 2021
|
@sumukhatv / @prsunny i have cherry-picked in 201911. Test file could not get cherry-picked. Please see if things are fine with python2 and there is no exception. |
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
|
This commit could not be cleanly cherry-pick to 202012. Please submit another PR. |
prsunny
pushed a commit
that referenced
this pull request
Sep 15, 2021
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
603ac53 (HEAD -> 201911, origin/201911) Advertise ipv6 link local address (sonic-net#1402) 9b0680c [acl_loader] Fix default DENY rule for V6 dataplane ACLs (sonic-net#1281) 25e64ce [show] Fix `show ip bgp sum` (sonic-net#1194) 4709da0 Revert "Add FW dump with new SAI implementation (sonic-net#1298)" (sonic-net#1408) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Modify the neighbor_advertiser script to advertise ipv6 link local address
This PR resolves sonic-net/sonic-buildimage#6599
- How I did it
Add ipv6 link local address to the slice returned by the neighbor advertiser script
- How to verify it
Added the verification logic to the neighbor_advertiser test
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)