Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fast-reboot] Fix dump script to support PortChannels in a VLAN group [201911] #1547

Merged
merged 3 commits into from
Apr 6, 2021
Merged

[fast-reboot] Fix dump script to support PortChannels in a VLAN group [201911] #1547

merged 3 commits into from
Apr 6, 2021

Conversation

shlomibitton
Copy link
Contributor

- What I did
Add PortChannels to the list of interfaces (port_id_2_iface) to support FDB dump for PortChannel in a VLAN group.
Fixes sonic-net/sonic-buildimage#4793
This PR is the 201911 version of the original PR: #1393

- How I did it

  • Get LAG ID from the DB.
  • Find the LAG name from APP DB.
  • Add it to the list of 'port_id_2_iface' to be used.

- How to verify it
Reproduce the issue mentioned on this PR and try to run fast-reboot with this fix.

- Previous command output (if the output of a command-line utility has changed)
Traceback:
src_ifs = {map_mac_ip_per_vlan[vlan_name][dst_mac] for vlan_name, dst_mac, _ in arp_entries}
KeyError: 'b8:59:9f:a8:e2:00'

- New command output (if the output of a command-line utility has changed)
Success .

…#1393)

Add PortChannels to the list of interfaces (port_id_2_iface) to support FDB dump for PortChannel in a VLAN group.

Fix sonic-net/sonic-buildimage#4793

- How I did it

- Get LAG ID from the DB.
- Find the LAG name from APP DB.
- Add it to the list of 'port_id_2_iface' to be used.

- How to verify it
Reproduce the issue mentioned on this PR and try to run fast-reboot with this fix.

- Previous command output (if the output of a command-line utility has changed)
Traceback:
src_ifs = {map_mac_ip_per_vlan[vlan_name][dst_mac] for vlan_name, dst_mac, _ in arp_entries}
KeyError: 'b8:59:9f:a8:e2:00'

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
@shlomibitton shlomibitton changed the title [fast-reboot] Fix dump script to support PortChannels in a VLAN group [fast-reboot] Fix dump script to support PortChannels in a VLAN group [201911] Apr 5, 2021
setup.py Outdated Show resolved Hide resolved
@qiluo-msft
Copy link
Contributor

Running deepdiff-5.2.3/setup.py -q bdist_egg --dist-dir /tmp/easy_install-WxLknq/deepdiff-5.2.3/egg-dist-tmp-OI2vaL
error: Setup script exited with Python 2 is not supported anymore. The last version of DeepDiff that supported Py2 was 3.3.0

lguohan pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Apr 6, 2021
…s test (#7231)

Add this package to help sonic-net/sonic-utilities#1547

Only needed on 201911 branch because future branchs build sonic-utilities in sonic-slave-buster.
@sonic-net sonic-net deleted a comment from azure-pipelines bot Apr 6, 2021
qiluo-msft added a commit to Azure/sonic-build-tools that referenced this pull request Apr 6, 2021
@qiluo-msft qiluo-msft merged commit b39dbbc into sonic-net:201911 Apr 6, 2021
@shlomibitton shlomibitton deleted the fast_reboot_dump_portchannel_fix_201911 branch July 27, 2021 16:33
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
b39dbbc 2021-04-06 | [fast-reboot] Fix dump script to support PortChannels in a VLAN group [201911] (sonic-net#1547) [shlomibitton]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants