Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use natural sort for 'show acl table' ports #157

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

zhenggen-xu
Copy link
Collaborator

This change is to use natural sort for ports of the ACL_TABLE.

@jleveque jleveque merged commit f57427e into sonic-net:master Dec 1, 2017
@zhenggen-xu zhenggen-xu deleted the aclloader-fix branch May 4, 2021 21:05
vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
…ore unit tests (sonic-net#157)

- Refactor thermalctld to reduce the amount of code in infinite loops, thus allowing us better unit test coverage
- Refactor mock_platform.py such that it inherits from sonic-platform-common in order to ensure it is aligned with the current API definitions (this introduces a test-time dependency on the sonic-platform-common package)
- Increase pytest verbosity to prevent truncation of error messages

- Miscellaneous cleanup:
    - Fixes to grammar
    - Remove unnecessary punctuation from log messages

- Increase overall unit test unit test coverage from 73% to 93%
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
- Make `_read_eeprom_specific_bytes` Python3 and Python2 compatible
- Change a stray `self.eep_dict.iteritems()` call to `self.eep_dict.items()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants