[201911][acl] Use a list instead of a comma-separated string for ACL port list #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port list Signed-off-by: Danny Allen <daall@microsoft.com> foo
qiluo-msft
approved these changes
Apr 22, 2021
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
a364614 2021-04-22 | [201911][acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1576) [Danny Allen] 391e524 2021-04-15 | [201911] Fix Multi-ASIC show specific resursive route (sonic-net#1563) [gechiang]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
How I did it
I discovered that using the @ syntax to insert the port list as a comma-separated list/array actually causes the port list to be deleted when the same table is config add-ed multiple times. Using a list works. (We still need to determine the root cause for why the @ syntax fails).
How to verify it
Updated the tests and ran the command locally to verify the fix. Still working on adding a new regression test case for this.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)