Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drop counter] Bug fix: scripts/pg-drop isn't installed on the switch #1586

Closed

Conversation

stephenxs
Copy link
Collaborator

What I did

Bug fix: scripts/pg-drop isn't installed on the switch.

admin@sonic:~$ show priority-group drop counters
/bin/sh: 1: pg-drop: not found

Signed-off-by: Stephen Sun stephens@nvidia.com

How I did it

Any newly added scripts should be put in setup.py in order to have it installed on the switch.

How to verify it

Run command show priority-group drop counters

admin@sonic:/usr/local/bin$ show priority-group drop counters 
Ingress PG dropped packets:
       Port    PG0    PG1    PG2    PG3    PG4    PG5    PG6    PG7
-----------  -----  -----  -----  -----  -----  -----  -----  -----
  Ethernet0      0      0      0      0      0      0      0      0
  Ethernet4      0      0      0      0      0      0      0      0
  Ethernet8      0      0      0      0      0      0      0      0
 Ethernet12      0      0      0      0      0      0      0      0
 Ethernet16      0      0      0      0      0      0      0      0
 Ethernet20      0      0      0      0      0      0      0      0
 Ethernet24      0      0      0      0      0      0      0      0
 Ethernet28      0      0      0      0      0      0      0      0
 Ethernet32      0      0      0      0      0      0      0      0
 Ethernet36      0      0      0      0      0      0      0      0
 Ethernet40      0      0      0      0      0      0      0      0
 Ethernet44      0      0      0      0      0      0      0      0
 Ethernet48      0      0      0      0      0      0      0      0
 Ethernet52      0      0      0      0      0      0      0      0
 Ethernet56      0      0      0      0      0      0      0      0
 Ethernet60      0      0      0      0      0      0      0      0
 Ethernet64      0      0      0      0      0      0      0      0
 Ethernet68      0      0      0      0      0      0      0      0
 Ethernet72      0      0      0      0      0      0      0      0
 Ethernet76      0      0      0      0      0      0      0      0
 Ethernet80      0      0      0      0      0      0      0      0
 Ethernet84      0      0      0      0      0      0      0      0
 Ethernet88      0      0      0      0      0      0      0      0
 Ethernet92      0      0      0      0      0      0      0      0
 Ethernet96      0      0      0      0      0      0      0      0
Ethernet100      0      0      0      0      0      0      0      0
Ethernet104      0      0      0      0      0      0      0      0
Ethernet108      0      0      0      0      0      0      0      0
Ethernet112      0      0      0      0      0      0      0      0
Ethernet116      0      0      0      0      0      0      0      0
Ethernet120      0      0      0      0      0      0      0      0
Ethernet124      0      0      0      0      0      0      0      0
Ethernet128      0      0      0      0      0      0      0      0
Ethernet132      0      0      0      0      0      0      0      0
Ethernet136      0      0      0      0      0      0      0      0
Ethernet140      0      0      0      0      0      0      0      0
Ethernet144      0      0      0      0      0      0      0      0
Ethernet148      0      0      0      0      0      0      0      0
Ethernet152      0      0      0      0      0      0      0      0
Ethernet156      0      0      0      0      0      0      0      0
Ethernet160      0      0      0      0      0      0      0      0
Ethernet164      0      0      0      0      0      0      0      0
Ethernet168      0      0      0      0      0      0      0      0
Ethernet172      0      0      0      0      0      0      0      0
Ethernet176      0      0      0      0      0      0      0      0
Ethernet180      0      0      0      0      0      0      0      0
Ethernet184      0      0      0      0      0      0      0      0
Ethernet188      0      0      0      0      0      0      0      0
Ethernet192      0      0      0      0      0      0      0      0
Ethernet196      0      0      0      0      0      0      0      0
Ethernet200      0      0      0      0      0      0      0      0
Ethernet204      0      0      0      0      0      0      0      0
Ethernet208      0      0      0      0      0      0      0      0
Ethernet212      0      0      0      0      0      0      0      0
Ethernet216      0      0      0      0      0      0      0      0
Ethernet220      0      0      0      0      0      0      0      0

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@ayurkiv-nvda
Copy link
Contributor

same changes were introduced in this PR #1583

@stephenxs
Copy link
Collaborator Author

same changes were introduced in this PR #1583

That’s great:)
Close this one then.

@stephenxs stephenxs closed this Apr 30, 2021
@stephenxs stephenxs deleted the fix-pg-drop-not-installed branch May 8, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants