Build a python3 wheel with sonic_psu #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
taoyl-ms
approved these changes
Dec 6, 2017
jleveque
reviewed
Dec 6, 2017
| from setuptools import setup | ||
| import unittest | ||
|
|
||
| # For python3 wheel, we currently don't need test | ||
| # TODO: build python3 wheel of all the dependencies, and remove conditional test |
There was a problem hiding this comment.
Do we really plan to do this in the future?
It is my understanding that this is a temporary solution until we break the sonic Python modules out into their own package, separate from sonic-utilities, then we will build the modules package for both Python 2 and 3, correct?
There was a problem hiding this comment.
OK. This is an alternative, and we can remove TODO if either is achieved.
jleveque
approved these changes
Dec 6, 2017
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
…'N/A' (sonic-net#162) Currently, some vendors are using custom transceiver info parsers which do not yet provide the `dom_capability` field in the results of `get_transceiver_info()`. However, PR sonic-net/sonic-platform-daemons#72 introduced storing this value to State DB under the assumption that it would always be present. On platforms where this value is not present, it would cause xcvrd to crash (see issue: sonic-net/sonic-buildimage#6978). This change will prevent a crash if it is not present, and will in turn save `'N/A'` as the `dom_capability` value in State DB.
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
… internal and nic temperature and voltage (sonic-net#162) * [sonic_y_cable] add support for retreiving firmware info for Y cable, internal and nic tempertaure and voltage This PR provides the necessary infrastructure to add support for getting firmware information running on the three ends of Y cable. Also we get internal and nic side temperature and voltage What is the motivation for this PR? To add the necessary support for fetching firmware info for Y cable, internal and nic temperature and voltage How did you do it? Added the changes in sonic-platform-common module in the y_cable.py file How did you verify/test it? opened a python shell and ran the API's manually and test verified the values are correct. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can install the wheel in a python3 environment