[201911][db_migrator] fix old 1911 feature config migration to a new … #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one. This change is in addition to sonic-net#1522. The init_cfg.json may have important fields added to configuration, while in previous fix these entries will not be added when table already exists. This change fixes this behaviour. Also, in order to preserve users auto_restart configuration a special logic for migrating CONTAINER_FEATURE table has been implemented. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
@abdosi FYI, we will need to take it into 201911 as soon as possible. |
|
@yxieca could you please help to review? it is an urgent fix needed. |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
yxieca
approved these changes
Jun 3, 2021
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
* 42354e6 [201911][db_migrator] fix old 1911 feature config migration to a new … (sonic-net#1637) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Revert "[201911][db_migrator] fix old 1911 feature config migration to a new … (sonic-net#1637)" Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in addition to #1522.
The init_cfg.json may have important fields added to configuration, while in
previous fix these entries will not be added when table already exists.
This change fixes this behaviour. Also, in order to preserve users auto_restart
configuration a special logic for migrating CONTAINER_FEATURE table has been implemented.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
What I did
Implemented migration for old FEATURE table.
How I did it
Added migrate_feature().
How to verify it
Old 201911 with CONTAINER_FEATURE and old FEATURE schema upgrade to latest 201911.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)