[intfstat] Fix logic in RIF counters to print right stats #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liat-grozovik FYI. |
dgsudharsan
suggested changes
Jul 31, 2021
scripts/intfstat
Outdated
Comment on lines
321
to
329
| pickle.dump(cnstat_dict, open(cnstat_fqn_file, 'wb')) | ||
| except IOError as e: | ||
| sys.exit(e.errno) |
There was a problem hiding this comment.
If we are making the general file upto date, can you please explain the need for the interface specific file? In my opinion one file should be good enough to save stats.
There was a problem hiding this comment.
There is another feature we need to take into consideration - tag_name.
If a user wants to clear counters with a certain tag, we need to keep stats in this tag file.
so I removed the interface name in file which is indeed unneeded, but changed the logic in the script to not brake tag_name logic.
noaOrMlnx
force-pushed
the
rif_logic_fix
branch
from
87b158c
to
57400af
Compare
|
/azpw run |
dgsudharsan
suggested changes
Aug 3, 2021
There was a problem hiding this comment.
Can you please add UT to this file.https://github.com/Azure/sonic-utilities/blob/master/tests/intfstat_test.py ?
noaOrMlnx
force-pushed
the
rif_logic_fix
branch
from
57400af
to
7247566
Compare
dgsudharsan
previously approved these changes
Aug 7, 2021
noaOrMlnx
force-pushed
the
rif_logic_fix
branch
from
7247566
to
fb202ba
Compare
dgsudharsan
approved these changes
Aug 17, 2021
prsunny
approved these changes
Aug 27, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 30, 2021
*when deleting for a certain interface, add the info to the general file. *when querying for a certain interface, check the general file as well.
judyjoseph
pushed a commit
that referenced
this pull request
Sep 2, 2021
*when deleting for a certain interface, add the info to the general file. *when querying for a certain interface, check the general file as well.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
…627) 7041400 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773) (sonic-net#1786) 399d370 Fix logic in RIF counters print (sonic-net#1732) 8329544 [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756) 193b028 [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663) 2c82bcf [neighbor_advertiser] Use existing tunnel if present for creating tunnel mappings (sonic-net#1589) 8e22960 [202012][Config] Update config command of Kdump. (sonic-net#1778) be3e5c6 [show][config] cli refactor for muxcable with abstract class implementation from vendors (sonic-net#1722) (sonic-net#1782)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix logic in scripts/intfstat file.
Before the change:
If a user cleared all counters using
sonic-clear rifcounterscommand and then queried for rif counters with a certain interface (e.g.show interfaces counters rif Ethernet0), the user would see the older stats. meaning the clear was not performed.The reason for this is that when we do sonic-clear rifcounters, the counters are not really being cleared, but current stats are saved into a file, and in the next counters query, it will calculate the diff between current counters and the saved counters.
If the clear was performed in general (without an interface name), it's saved to a general file (e.g. 0).
If the clear was performed for a certain interface, it's saved to an interface file (e.g. 0-Ethernet0).
so when we clear in one method and then query for the other, we can receive the info from the wrong file and display different stats.
Fix issue - sonic-net/sonic-buildimage#8394
How I did it
Add the logic:
when deleting for a certain interface, add the info to the general file.
when querying for a certain interface, check the general file as well.
How to verify it
send traffic to interface
check general rif table (
show interfaces counters rif)clear general rifcounters (
sonic-clear rifcounters)check that the specific interface table is also updated (
show interfaces counters rif Ethernet0)send traffic to interface
clear interface table (
sonic-clear rifcounters Ethernet0)check that general table is updated as well (
show interfaces counters rif)Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
N/A