[show][platform] Revise chassis info fallback to only fall back on pmon crash #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sujinmkang Can you please review? |
|
@alexrallen and @dgsudharsan it looks ok to me but will wait for Dell to perform more verification and confirm the fix. |
sujinmkang
approved these changes
Aug 19, 2021
|
Required for 202106 |
judyjoseph
pushed a commit
that referenced
this pull request
Sep 14, 2021
…on crash (#1751) What I did Changed the behavior of the get_chassis_info() function which is used by show version and show platform summary to report the serial / model / revision of the switch to only attempt to call the platform API if pmon completely failed to provision STATE_DB with CHASSIS_INFO How I did it Altered get_chassis_info() according to the above behavior. See changelog for details. How to verify it Verify show platform summary and show version correctly report chassis info. Delete the CHASSIS_INFO table from STATE_DB Verify show platform summary and show version still correctly report the info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Changed the behavior of the
get_chassis_info()function which is used byshow versionandshow platform summaryto report the serial / model / revision of the switch to only attempt to call the platform API if pmon completely failed to provision STATE_DB with CHASSIS_INFOHow I did it
Altered
get_chassis_info()according to the above behavior. See changelog for details.How to verify it
Verify
show platform summaryandshow versioncorrectly report chassis info.Delete the
CHASSIS_INFOtable fromSTATE_DBVerify
show platform summaryandshow versionstill correctly report the info.