[Fast-Reboot]: Add directed GARP #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Dec 20, 2017
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[201911] [xcvrd] Gracefully handle improper 'specification_compliance' field; also fix other potential bugs (sonic-net#178) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Description Update ThermalManagerBase to load an interval field from thermal_policy.json if it is available and provide a getter for this interval. Motivation and Context This interval can be used by thermalctld to run policies at an interval specified in thermal_policy.json, rather than a fixed constant (currently 60 seconds). How Has This Been Tested? Verified that thermalctld runs without exiting. Also ran test_thermalctld.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a new functionality into fast-reboot-dumper.py. This script is called right before fast-reboot procedure to save dumps of fdb and arp entries. I've added a new functionality - send directed GARP requests for every NEIGHBOR entry in SONiC. It allows SONiC to be sure that host machines on vlan interfaces will keep their arp entries to SONiC device as long as possible. Previously host machines could expire arp entries to SONiC device when SONiC device in Fast-Reboot procedure.
- How I did it
I extract all required information from arp and fdb entries and then generate ARP entries using Linux raw sockets
- How to verify it
Use tcpdump
sudo tcpdump -iEthernet10 -nevvfor example- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)