[crm]: Add utility for CRM configuration #187

volodymyrsamotiy · 2018-01-15T14:36:04Z

Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com

Initial CRM UI utility implementation for review. Please do not merge yet.

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

prsunny

As mentioned in section <2.7.3 Show CLI command>, should we also incorporate this to show utility?

prsunny · 2018-01-25T01:05:49Z

crm/main.py

+            for res in ["ipv4_route", "ipv6_route", "ipv4_nexthop", "ipv6_nexthop", "ipv4_neighbor", "ipv6_neighbor",
+                        "nexthop_group_member", "nexthop_group_object", "acl_table", "acl_group", "acl_entry",
+                        "acl_counter", "fdb_entry"]:
+                data.append([res, crm_info[res + "_threshold_type"], crm_info[res + "_low_threshold"], crm_info[res + "_high_threshold"]])


is crm_info[] from config_db prefixed with "crm" as mentioned in the design spec (CRM_IPV4_ROUTE_THRESHOLD_TYPE)?. Can you place the config_db output for understanding?

Currently "CONFIG_DB" output looks as following:

127.0.0.1:6379[4]> HGETALL CRM|Config 1) "ipv4_route_threshold_type" 2) "percentage" 3) "ipv4_route_low_threshold" 4) "70" 5) "ipv4_route_high_threshold" 6) "85" ...

prsunny · 2018-01-25T01:20:26Z

crm/main.py

+        print tabulate(data, headers=header, tablefmt="simple", missingval="")
+        print '\n'
+
+    def show_acl_table_resources(self, table_id):


Show table resource requires user to specify table_id? Just thinking if we can also display the complete table. What do you say?

Was this intended in design spec, [resources|thresholds] acl group [entry|counter]

Currently it requires table_id, I agree that it is better to display complete table. Will check what we can do.

prsunny · 2018-01-25T01:22:57Z

crm/main.py

+@click.argument('value', type=click.Choice(['percentage', 'used', 'free']))
+@click.pass_context
+def type(ctx, value):
+    """CRM threshod type configuration"""


Typo - threshold.. Please correct the ones below as well

prsunny · 2018-01-25T01:31:32Z

Can you show one sample output for any one of the threshold and resource?

volodymyrsamotiy · 2018-01-29T16:09:18Z

Yes, I will incorporate this script to the "show" and "config" utilities.

volodymyrsamotiy · 2018-01-29T16:12:13Z

Please find "threshold" sample output below.

# crm show thresholds all


Resource Name         Threshold Type      Low Threshold    High Threshold
--------------------  ----------------  ---------------  ----------------
ipv4_route            percentage                     70                85
ipv6_route            percentage                     70                85
ipv4_nexthop          percentage                     70                85
ipv6_nexthop          percentage                     70                85
ipv4_neighbor         percentage                     70                85
ipv6_neighbor         percentage                     70                85
nexthop_group_member  percentage                     70                85
nexthop_group_object  percentage                     70                85
acl_table             percentage                     70                85
acl_group             percentage                     70                85
acl_entry             percentage                     70                85
acl_counter           percentage                     70                85
fdb_entry             percentage                     70                85

volodymyrsamotiy · 2018-01-29T16:13:25Z

Please find "resource" sample output below.

# crm show resources all


Resource Name           Used Count    Available Count
--------------------  ------------  -----------------
ipv4_route                    6417              96925
ipv6_route                    6414              96925
ipv4_nexthop                     5              57314
ipv6_nexthop                     4              57314
ipv4_neighbor                    5              96925
ipv6_neighbor                    4              22114
nexthop_group_member             8              57314
nexthop_group_object             2              57314
fdb_entry                        1              96925




Stage    Bind Point    Resource Name      Used Count    Available Count
-------  ------------  ---------------  ------------  -----------------
INGRESS  PORT          acl_group                   0                399
INGRESS  PORT          acl_table                   0                393
INGRESS  LAG           acl_group                   0                399
INGRESS  LAG           acl_table                   0                393
INGRESS  VLAN          acl_group                   0                399
INGRESS  VLAN          acl_table                   0                393
INGRESS  RIF           acl_group                   0                399
INGRESS  RIF           acl_table                   0                393
INGRESS  SWITCH        acl_group                   0                399
INGRESS  SWITCH        acl_table                   0                393
EGRESS   PORT          acl_group                   0                399
EGRESS   PORT          acl_table                   1                393
...

prsunny

Approving. Few pending changes are not critical and can be addressed in future commits

lguohan · 2018-02-09T02:50:01Z

can you change the name to nexthop_group since other object do not have this suffix.

nexthop_group_object             2              57314

lguohan · 2018-02-09T02:51:00Z

can give the output for acl_entry/acl_counter for a table?

* Change "show acl table" command in order to show complete table without passing table ID * Rename "nexthop_group_object" resource to "nexthop_group" * Change CRM polling interval represantation from minutes to seconds Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

volodymyrsamotiy · 2018-02-14T20:07:43Z

Changed "show acl table" command in order to show complete table without passing table ID
Renamed "nexthop_group_object" resource to "nexthop_group"
Changed CRM polling interval represantation from minutes to seconds

volodymyrsamotiy · 2018-02-14T20:19:35Z

Below is the output for the ACL per table resources: entry and counter.
(now ACL tables are also shown in "crm show resources all" command)

# crm show resources acl table


Table ID         Resource Name      Used Count    Available Count
---------------  ---------------  ------------  -----------------
0x70000000002bd  acl_entry                   1              13813
0x70000000002bd  acl_counter                 1              13813

prsunny · 2018-02-15T23:05:34Z

crm/main.py

        data = []

-        crm_stats = countersdb.get_all(countersdb.COUNTERS_DB, 'CRM:ACL_TABLE_STATS:{0}'.format(table_id))
+        # Retrieve all ACL table keys from CRM:ACL_TABLE_STATS
+        output = os.popen("docker exec -i database redis-cli --raw -n 2 KEYS *CRM:ACL_TABLE_STATS*").readlines()


In general, subprocess is being used instead of os.popen

prsunny · 2018-02-15T23:09:34Z

crm/main.py

        """
        CRM Handler to display ACL table information.
        """
        countersdb = swsssdk.SonicV2Connector(host='127.0.0.1')
        countersdb.connect(countersdb.COUNTERS_DB)

-        header = ("Resource Name", "Used Count", "Available Count")
+        header = ("Table ID", "Resource Name", "Used Count", "Available Count")


Just checking, is it possible to display Table name as well, if it's available in the DB?

Looks like no, currently we cannot display ACL table name here.

* Use subprocess instead of os.popen * Fix incorrect output of ACL table info Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

RB=1288101 G=lnos-reviewers R=ntrianta,pmao,rmolina,sfardeen,zxu * github: [acl_loader] Support Service ACL binding to multiple services (sonic-net#236) [show] Rename 'show session' to 'show mirror session' (sonic-net#235) [pfcstat]: create python cli tool to show pfc counters (sonic-net#233) [queuestat] add python CLI tool to show queue counters [acl-loader] Not to crash upon invalid rule (sonic-net#232) Show FDB type in fdbshow/show mac (sonic-net#231) [show] add 'show runningconfiguration all' subcommand (sonic-net#230) [reboot scripts] remove -t option in docker exec commands (sonic-net#228) [reboot] reduce stop service to only stop syncd (sonic-net#223) [crm]: Fix failures in CLI show commands (sonic-net#221) [Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212) add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220) [config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218) [PFCWD]: set default configuration when enabled by default (sonic-net#213) Add fast-reboot support for Aboot based images (sonic-net#214) sonic-utilities: Format show vlan config output (sonic-net#210) [AAA] Support login(ascii) authentication type (sonic-net#217) [sfputil] Adapt new way of getting PLATFORM(sonic-net#216) [Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2 (sonic-net#211) Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208) Find correct opennsl module name before stopping it (sonic-net#207) [crm]: Add utility for CRM configuration (sonic-net#187) [reboot] update reboot script to retrieve platform with new format (sonic-net#206) Adapt to config engine change to load platform info properly (sonic-net#205) [config] Add qos clear and qos reload support (sonic-net#204) Dump default routes from APPL_DB table before fast-reboot (sonic-net#203) [acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202) [pfcwd]: add command to set pfcwd polling interval (sonic-net#192) [acl-loader] Prevent from hanging if run by non-root user (sonic-net#199) [config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197) Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196) [TACACS+]: Fix aaa show error without configuration (sonic-net#191) 'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195) [sonic-clear] add a clear fdb command (sonic-net#186)

qiluo-msft · 2020-01-28T02:11:13Z

crm/main.py

+        header = ("Table ID", "Resource Name", "Used Count", "Available Count")
+
+        # Retrieve all ACL table keys from CRM:ACL_TABLE_STATS
+        proc = Popen("docker exec -i database redis-cli --raw -n 2 KEYS *CRM:ACL_TABLE_STATS*", stdout=PIPE, stderr=PIPE, shell=True)


It exec another script to make DB operation. Could you please use redis-py or existing XxxxDBConnector/etc to do DB changes?

…common classes (sonic-net#187) #### Description Existing test will mix true swsscommon package with the mocked one in sonic_py_common #### Motivation and Context This is blocking sonic-net/sonic-buildimage#7655 #### How Has This Been Tested? Unit test

…net#187) Add a stop function to thermal manager. Allow thermalctld to call the stop function to stop run_policy function fast

[crm]: Add utility for CRM configuration

23af16e

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

volodymyrsamotiy force-pushed the master branch from 0789cec to 23af16e Compare January 16, 2018 15:38

prsunny reviewed Jan 25, 2018

View reviewed changes

prsunny approved these changes Feb 2, 2018

View reviewed changes

prsunny reviewed Feb 15, 2018

View reviewed changes

[crm]: Add utility for CRM configuration

4908cba

* Use subprocess instead of os.popen * Fix incorrect output of ACL table info Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>

prsunny approved these changes Feb 20, 2018

View reviewed changes

lguohan approved these changes Feb 21, 2018

View reviewed changes

lguohan merged commit 1a1b071 into sonic-net:master Feb 21, 2018

qiluo-msft reviewed Jan 28, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[crm]: Add utility for CRM configuration #187

[crm]: Add utility for CRM configuration #187

volodymyrsamotiy commented Jan 15, 2018

prsunny left a comment

prsunny Jan 25, 2018

volodymyrsamotiy Jan 29, 2018

prsunny Jan 25, 2018

volodymyrsamotiy Jan 29, 2018

prsunny Jan 25, 2018

prsunny commented Jan 25, 2018

volodymyrsamotiy commented Jan 29, 2018

volodymyrsamotiy commented Jan 29, 2018

volodymyrsamotiy commented Jan 29, 2018

prsunny left a comment

lguohan commented Feb 9, 2018

lguohan commented Feb 9, 2018

volodymyrsamotiy commented Feb 14, 2018

volodymyrsamotiy commented Feb 14, 2018

prsunny Feb 15, 2018

prsunny Feb 15, 2018

volodymyrsamotiy Feb 19, 2018

qiluo-msft Jan 28, 2020

[crm]: Add utility for CRM configuration #187

[crm]: Add utility for CRM configuration #187

Conversation

volodymyrsamotiy commented Jan 15, 2018

prsunny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsunny commented Jan 25, 2018

volodymyrsamotiy commented Jan 29, 2018

volodymyrsamotiy commented Jan 29, 2018

volodymyrsamotiy commented Jan 29, 2018

prsunny left a comment

Choose a reason for hiding this comment

lguohan commented Feb 9, 2018

lguohan commented Feb 9, 2018

volodymyrsamotiy commented Feb 14, 2018

volodymyrsamotiy commented Feb 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment