[port2alias]: Fix to get right number of return values #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from get_port_config. Modified to get ports from all namespaces and added unit test cases. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abdosi
approved these changes
Dec 6, 2021
5 tasks
Closed
5 tasks
abdosi
pushed a commit
that referenced
this pull request
Dec 8, 2021
What I did get_port_config was modified to return different set number of arguments in PR: sonic-net/sonic-buildimage#4222. Changes in this PR is: To address the different set of return values To get the ports from all namespaces To add unit-test How I did it Modify port2alias to read ports from all namespaces and also add unit-test How to verify it Test on single and multi-asic platforms. unit-test passed.
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
SuvarnaMeenakshi
added a commit
to SuvarnaMeenakshi/sonic-utilities
that referenced
this pull request
May 27, 2022
What I did get_port_config was modified to return different set number of arguments in PR: sonic-net/sonic-buildimage#4222. Changes in this PR is: To address the different set of return values To get the ports from all namespaces To add unit-test How I did it Modify port2alias to read ports from all namespaces and also add unit-test How to verify it Test on single and multi-asic platforms. unit-test passed. (cherry picked from commit 3714f63) Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
SuvarnaMeenakshi
added a commit
that referenced
this pull request
Jun 13, 2022
What I did Cherry-pick of #1906 to 202012 branch Fix conflict also few changes done to cherry-pick: get_port_config function takes asic id as argument in 2019/202012 branches Keep load_source of port2alias as module, as is used in unit-test in 202012 branch get_port_config was modified to return different set number of arguments in PR: sonic-net/sonic-buildimage#4222. Changes in this PR is: To address the different set of return values To get the ports from all namespaces To add unit-test Additional change done over the cherry-pick: added setup_class method in test case to load single asic mock db, this was done in pfcwd_test teardown method in 201911 and master branches. It is not done in 202012 branch, hence added setup_class method. How I did it Modify port2alias to read ports from all namespaces and also add unit-test How to verify it Verified on single and multi-asic DUTs with 202012 image.
|
202012 branch PR merged: #2188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from get_port_config. Modified to get ports from all
namespaces and added unit test cases.
Signed-off-by: SuvarnaMeenakshi sumeenak@microsoft.com
What I did
get_port_config was modified to return different set number of arguments in PR: sonic-net/sonic-buildimage#4222. Changes in this PR is:
How I did it
Modify port2alias to read ports from all namespaces and also add unit-test
How to verify it
Test on single and multi-asic platforms.
unit-test passed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)