[config] Fix snmpagentaddress doesn't support the uppercase letters for ipv6 address #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or ipv6 address (#4852) -What I did Snmpagentaddress now support upper letters input for ipv6 address Fix some grammer mistakes -How I did Convert all agentip to lower letters to match netifaces addresses delete ; after break, convert addfress to address -How to verify it 'sudo config snmpagentaddress add FC00:1::32 -v mgmt' The ipv6 address can be obtained by command 'sudo ifconfig'
xwjiang-ms
changed the title
-What I did Snmpagentaddress now support upper letters input for ipv6 address -How I did Compare the lower letter of input and netifaces addresses -How to verify it 'sudo config snmpagentaddress add FC00:1::32 -v mgmt' The ipv6 address can be obtained by command 'sudo ifconfig'
|
Do you intend to fix sonic-net/sonic-mgmt#4852? It is not clear from your PR description. |
qiluo-msft
reviewed
Jan 4, 2022
config/main.py
Outdated
| @@ -2490,11 +2492,11 @@ def add_snmp_agent_address(ctx, agentip, port, vrf): | |||
| for ipaddr in ipaddresses[ip_family[ip.version]]: | |||
| if agentip == ipaddr['addr']: | |||
There was a problem hiding this comment.
Currently the ConfigDB has no way to enforce the lowercase for SNMP_AGENT_ADDRESS_CONFIG key. So there may be already lowercase entries.
Suggest you compare ipv6 address case insensitive. This library may help https://docs.python.org/3/library/ipaddress.html
There was a problem hiding this comment.
I see, it's better to compare the lowercase of IPv6 addresses, and I have modified my PR, thanks.
|
@sumanbrcm Could you also help review? |
Yes I want to fix this issue, and I have edited the description. |
yxieca
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)