Try get port operational speed from STATE DB #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
previously approved these changes
Feb 14, 2022
prgeor
reviewed
Mar 2, 2022
prgeor
reviewed
Mar 7, 2022
prgeor
previously approved these changes
Mar 7, 2022
|
@Junchao-Mellanox could you check the build failure? |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
force-pushed
the
optimize-port-auto-neg
branch
from
c32ccf4
to
332712c
Compare
|
Did a rebase(no new change) to re-trigger the checkers, hope it fix the vs test failure. |
|
/azpw run Azure.sonic-utilities |
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Mar 15, 2022
keboliu
approved these changes
Mar 15, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Mar 20, 2022
* Try get port operatinal speed from STATE DB * Fix review comment * Fix review comment * Fix unit test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD change: sonic-net/SONiC#932
What I did
Part of the fix for issue sonic-net/sonic-buildimage#9595
How I did it
For script intfutil, portstat, voqutil, try to get port operational speed from STATE_DB first. If speed value is not present or is "N/A" in STATE DB, try to get port operational speed from APPL_DB, this is for backward compatible
How to verify it
Extend existing unit test cases
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)