-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBH] Implement Edit Flows #2093
Merged
liat-grozovik
merged 1 commit into
sonic-net:master
from
nazariig:master-pbh-edit-flows
Mar 30, 2022
Merged
[PBH] Implement Edit Flows #2093
liat-grozovik
merged 1 commit into
sonic-net:master
from
nazariig:master-pbh-edit-flows
Mar 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 1 alert when merging 8df89490d46d4eac866080b30cf66b32c9cf9b10 into 47c243e - view on LGTM.com new alerts:
|
nazariig
force-pushed
the
master-pbh-edit-flows
branch
from
March 7, 2022 16:19
8df8949
to
18d3f07
Compare
nazariig
force-pushed
the
master-pbh-edit-flows
branch
from
March 14, 2022 12:22
18d3f07
to
6e94246
Compare
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@anish-n please have a look |
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
nazariig
force-pushed
the
master-pbh-edit-flows
branch
from
March 17, 2022 16:26
6e94246
to
f632edb
Compare
@anish-n just a kind reminder |
stepanblyschak
approved these changes
Mar 18, 2022
@anish-n just a kind reminder |
kktheballer
reviewed
Mar 23, 2022
@kktheballer please review & approve |
kktheballer
approved these changes
Mar 30, 2022
liat-grozovik
approved these changes
Mar 30, 2022
6 tasks
judyjoseph
pushed a commit
that referenced
this pull request
Apr 4, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - How I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 4, 2022
In order to include the following commit: c752457 [PBH] Implement Edit Flows (sonic-net/sonic-utilities#2093) sonic-utilities f70dc27 [techsupport] Handle minor fixes of TS Lock and update auto-TS (#2114) 51d3550 Fix issues in clear_qos (#2122) 6d3aa1e [GCU] Optimizing moves by adding generators for keys/tables (#2120) 65a5a6b Fixing get port speed when oper status is down (#2123) c752457 [PBH] Implement Edit Flows (#2093) 827358f [debug dump] dump interface module added (#2070) Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects.
PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing.
HLD: sonic-net/SONiC#909
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)