Add support for Password Hardening #2121

davidpil2002 · 2022-03-29T09:40:35Z

What I did

Add Password Hardening CLI

How I did it

created the CLI by using YANG model generator, the YANG model can be found in the password hardening HLD https://github.com/Azure/SONiC/blob/master/doc/passw_hardening/hld_password_hardening.md#TestPlan
and also in sonic-buildimage will be merged in the path: src/sonic-yang-models/yang-models/sonic-passwh.yang

How to verify it

Manually:
you can use configurations command like"config passw-hardening policies " or
"show passw-hardening policies" (more examples in the HLD.)
Auto:
1.There are unitest of each policy including good & bad flow in this commit, that should pass.

2.There are tests in sonic-mgmt repo in the path: sonic-mgmt/tests/passw_hardening/
the test are end to end test and the are testing the config/show CLI commands as well.

Previous command output (if the output of a command-line utility has changed)

(new feature)

New command output (if the output of a command-line utility has changed)

root@r-panther-13:/home/admin# show passw-hardening policies
STATE    EXPIRATION    EXPIRATION WARNING    HISTORY    LEN MAX    LEN MIN    USERNAME PASSW MATCH    LOWER CLASS    UPPER CLASS    DIGITS CLASS    SPECIAL CLASS
-------  ------------  --------------------  ---------  ---------  ---------  ----------------------  -------------  -------------  --------------  ---------------
enabled      30           10                   4         100        30               false                 true            true            true          true

lgtm-com · 2022-03-29T09:51:40Z

This pull request introduces 1 alert when merging de719b1 into 827358f - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-04-07T14:46:11Z

This pull request introduces 1 alert when merging 03b3a57 into 9e2fbf4 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-04-13T12:27:40Z

This pull request introduces 1 alert when merging 8773eae into 576c9ef - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-04-13T12:41:36Z

This pull request introduces 1 alert when merging 83cec0c into 576c9ef - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-04-13T13:11:39Z

This pull request introduces 1 alert when merging 6b50c67 into 576c9ef - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-04-13T13:52:36Z

This pull request introduces 1 alert when merging e31dd01 into 576c9ef - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-04-13T14:29:16Z

This pull request introduces 1 alert when merging 90fd599 into 576c9ef - view on LGTM.com

new alerts:

1 for Unused import

dgsudharsan · 2022-04-18T16:56:42Z

show/plugins/sonic-passwh_yang.py

+
+import click
+import tabulate
+import natsort


Please remove natsort as it throws unused import.

dgsudharsan · 2022-04-19T03:19:21Z

tests/passw_hardening_test.py

@@ -0,0 +1,126 @@
+#!/usr/bin/env python


Why do we need tests for auto-generated CLI? Is it because of the coverage?

removed unuse import natsort

liat-grozovik · 2022-07-14T06:41:33Z

@liuh-80, @qiluo-msft kindly reminder to review and signoff

qiluo-msft · 2022-07-18T20:50:23Z

The latest coverage requirement (DIFF_COVER_CHECK_THRESHOLD) is 80%. Could you improve the coverage?

In reply to: 1188296645

qiluo-msft · 2022-07-18T20:52:43Z

config/plugins/sonic-passwh_yang.py

@@ -0,0 +1,537 @@
+"""
+Autogenerated config CLI plugin.


Is it possible to add the original command to generate code into the code itself as file header comment?

Should be an HLD/DOC about how to use the tool, I removed the augenerated comment

linux-foundation-easycla · 2022-08-03T09:39:43Z

✅ login: davidpil2002 (de719b1, 03b3a57, 90fd599, 4a88b70, 4b81398, 24814ba, b9ebf3a)
❌ The commit (6b50c67). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

zhangyanzhao · 2022-08-08T15:14:38Z

Liat will check with Qi on the review.

…nerator

davidpil2002 · 2022-08-09T15:31:27Z

The latest coverage requirement (DIFF_COVER_CHECK_THRESHOLD) is 80%. Could you improve the coverage?

I added more unitest and removed unused code.
the cov is now more than the threshold

davidpil2002 · 2022-08-09T15:34:21Z

answered all the comments, the P.R is ready to be approve/merge
@qiluo-msft
@liat-grozovik

qiluo-msft · 2022-08-09T22:55:35Z

@liuh-80 Could you review this PR?

davidpil2002 · 2022-08-10T05:46:33Z

@liat-grozovik pls can you help or derived me about this EasyCLA authorization issue?

liat-grozovik · 2022-08-24T08:59:58Z

/easycla

liat-grozovik · 2022-08-24T09:00:40Z

@liuh-80 we need to close this feature review as it is for 202205. can you please help to approve the PR?

liuh-80 · 2022-08-25T00:29:56Z

/easycla

liuh-80 · 2022-08-25T00:31:39Z

@liat-grozovik, please fix the easycla issue, then I can approve this PR.

liuh-80

I will approve again after fix easycla issue.

config/plugins/sonic-passwh_yang.py

davidpil2002 · 2022-08-25T07:06:59Z

/easycla

liuh-80 · 2022-08-26T03:25:39Z

❌ The commit (6b50c67). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

Please fix user name and emaill address issue on this commit:

❌ The commit (6b50c67). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

zhangyanzhao · 2022-08-26T03:39:15Z

@davidpil2002 can you please sign the EasyCLA to unblock the merge process? Thanks. @liat-grozovik for viz

davidpil2002 · 2022-08-28T07:18:50Z

/easycla

davidpil2002 · 2022-08-28T07:23:22Z

/easycla

davidpil2002 · 2022-08-28T07:24:28Z

/easycla

davidpil2002 · 2022-08-28T08:27:30Z

/easycla

…ening_cli

liuh-80 · 2022-08-29T04:18:21Z

@davidpil2002 , the CLA issue caused by this commit: 6b50c67

In this commit, your ID is 'davidpil'

In other commit which does not has the CLA issue, your ID is 'davidpil2002', so please check and fix your ID in that commit, then CLA will pass.

davidpil2002 · 2022-08-29T06:35:40Z

@davidpil2002 , the CLA issue caused by this commit: 6b50c67

In this commit, your ID is 'davidpil'

In other commit which does not has the CLA issue, your ID is 'davidpil2002', so please check and fix your ID in that commit, then CLA will pass.

I fixed this issue by creating a new PR with similar name:#2338

add Password Hardening CLI

de719b1

davidpil2002 mentioned this pull request Mar 29, 2022

Add support for Password Hardening sonic-net/sonic-buildimage#10323

Merged

7 tasks

Merge branch 'Azure:master' into password_hardening_cli

03b3a57

davidpil2002 force-pushed the password_hardening_cli branch from 8773eae to 83cec0c Compare April 13, 2022 12:33

Add Password Hardening CLI test

6b50c67

davidpil2002 force-pushed the password_hardening_cli branch from 83cec0c to 6b50c67 Compare April 13, 2022 13:03

Merge branch 'Azure:master' into password_hardening_cli

90fd599

davidpil2002 force-pushed the password_hardening_cli branch from e31dd01 to 90fd599 Compare April 13, 2022 14:18

liat-grozovik changed the title ~~add Password Hardening CLI~~ Password Hardening CLI Apr 13, 2022

This was referenced Apr 13, 2022

Password Hardening HLD sonic-net/SONiC#874

Merged

High level design for route flow counter sonic-net/SONiC#908

Merged

liat-grozovik changed the title ~~Password Hardening CLI~~ Add support for Password Hardening Apr 13, 2022

liat-grozovik requested review from dgsudharsan and liuh-80 April 18, 2022 08:27

dgsudharsan suggested changes Apr 18, 2022

View reviewed changes

dgsudharsan suggested changes Apr 19, 2022

View reviewed changes

Update sonic-passwh_yang.py

4a88b70

removed unuse import natsort

zhangyanzhao requested a review from qiluo-msft June 27, 2022 16:04

liat-grozovik added the Request for 202205 Branch label Jul 14, 2022

qiluo-msft reviewed Jul 18, 2022

View reviewed changes

[password hardening]Add test to coverage bad flows

4b81398

[password hardening]remove unuse functions created by the auto cli ge…

24814ba

…nerator

liuh-80 approved these changes Aug 25, 2022

View reviewed changes

config/plugins/sonic-passwh_yang.py Show resolved Hide resolved

davidpil2002 closed this Aug 28, 2022

davidpil2002 reopened this Aug 28, 2022

davidpil2002 closed this Aug 28, 2022

davidpil2002 reopened this Aug 28, 2022

davidpil2002 closed this Aug 28, 2022

davidpil2002 reopened this Aug 28, 2022

Merge remote-tracking branch 'origin_david/master' into password_hard…

b9ebf3a

…ening_cli

liat-grozovik closed this Sep 4, 2022

yxieca removed the Request for 202205 Branch label Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Password Hardening #2121

Add support for Password Hardening #2121

davidpil2002 commented Mar 29, 2022 •

edited

Loading

lgtm-com bot commented Mar 29, 2022

lgtm-com bot commented Apr 7, 2022

lgtm-com bot commented Apr 13, 2022

lgtm-com bot commented Apr 13, 2022

lgtm-com bot commented Apr 13, 2022

lgtm-com bot commented Apr 13, 2022

lgtm-com bot commented Apr 13, 2022

dgsudharsan Apr 18, 2022

dgsudharsan Apr 19, 2022

davidpil2002 Apr 20, 2022

liat-grozovik commented Jul 14, 2022

qiluo-msft commented Jul 18, 2022 •

edited

Loading

qiluo-msft Jul 18, 2022

davidpil2002 Aug 9, 2022

linux-foundation-easycla bot commented Aug 3, 2022 •

edited

Loading

zhangyanzhao commented Aug 8, 2022

davidpil2002 commented Aug 9, 2022

davidpil2002 commented Aug 9, 2022 •

edited

Loading

qiluo-msft commented Aug 9, 2022

davidpil2002 commented Aug 10, 2022

liat-grozovik commented Aug 24, 2022

liat-grozovik commented Aug 24, 2022

liuh-80 commented Aug 25, 2022

liuh-80 commented Aug 25, 2022

liuh-80 left a comment

davidpil2002 commented Aug 25, 2022

liuh-80 commented Aug 26, 2022

zhangyanzhao commented Aug 26, 2022

davidpil2002 commented Aug 28, 2022

davidpil2002 commented Aug 28, 2022

davidpil2002 commented Aug 28, 2022

davidpil2002 commented Aug 28, 2022

liuh-80 commented Aug 29, 2022

davidpil2002 commented Aug 29, 2022

Add support for Password Hardening #2121

Add support for Password Hardening #2121

Conversation

davidpil2002 commented Mar 29, 2022 • edited Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

lgtm-com bot commented Mar 29, 2022

lgtm-com bot commented Apr 7, 2022

lgtm-com bot commented Apr 13, 2022

lgtm-com bot commented Apr 13, 2022

lgtm-com bot commented Apr 13, 2022

lgtm-com bot commented Apr 13, 2022

lgtm-com bot commented Apr 13, 2022

dgsudharsan Apr 18, 2022

Choose a reason for hiding this comment

dgsudharsan Apr 19, 2022

Choose a reason for hiding this comment

davidpil2002 Apr 20, 2022

Choose a reason for hiding this comment

liat-grozovik commented Jul 14, 2022

qiluo-msft commented Jul 18, 2022 • edited Loading

qiluo-msft Jul 18, 2022

Choose a reason for hiding this comment

davidpil2002 Aug 9, 2022

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Aug 3, 2022 • edited Loading

zhangyanzhao commented Aug 8, 2022

davidpil2002 commented Aug 9, 2022

davidpil2002 commented Aug 9, 2022 • edited Loading

qiluo-msft commented Aug 9, 2022

davidpil2002 commented Aug 10, 2022

liat-grozovik commented Aug 24, 2022

liat-grozovik commented Aug 24, 2022

liuh-80 commented Aug 25, 2022

liuh-80 commented Aug 25, 2022

liuh-80 left a comment

Choose a reason for hiding this comment

davidpil2002 commented Aug 25, 2022

liuh-80 commented Aug 26, 2022

zhangyanzhao commented Aug 26, 2022

davidpil2002 commented Aug 28, 2022

davidpil2002 commented Aug 28, 2022

davidpil2002 commented Aug 28, 2022

davidpil2002 commented Aug 28, 2022

liuh-80 commented Aug 29, 2022

davidpil2002 commented Aug 29, 2022

davidpil2002 commented Mar 29, 2022 •

edited

Loading

qiluo-msft commented Jul 18, 2022 •

edited

Loading

linux-foundation-easycla bot commented Aug 3, 2022 •

edited

Loading

davidpil2002 commented Aug 9, 2022 •

edited

Loading