[scripts/fast-reboot] stop timers in advance #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
liat-grozovik
approved these changes
Apr 8, 2022
|
@yxieca could you please help to signoff? |
vaibhavhd
approved these changes
Apr 12, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Apr 13, 2022
- What I did Service timers may trigger service start in the middle of warm-reboot. Stopping them in advance prevents this issue. - How I did it Stopped all service timers that are part of sonic-delayed.target - How to verify it Run warm-reboot. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
judyjoseph
pushed a commit
that referenced
this pull request
Apr 18, 2022
- What I did Service timers may trigger service start in the middle of warm-reboot. Stopping them in advance prevents this issue. - How I did it Stopped all service timers that are part of sonic-delayed.target - How to verify it Run warm-reboot. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
added a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
``` 08495be [scripts/fast-reboot] Shutdown remaining containers through systemd (sonic-net#2133) fa07373 [scripts/fast-reboot] stop timers in advance (sonic-net#2131) 00ef80e [show][muxcable] Decrease the timeout for show mux status/hwmode (sonic-net#2130) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
What I did
Service timers may trigger service start in the middle of warm-reboot. Stopping them in advance prevents this issue.
How I did it
Stopped all service timers that are part of sonic-delayed.target
How to verify it
Run warm-reboot.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Requested for: 202111, 202012