YANG validation for ConfigDB Updates: portchannel add/remove, loopback interface, VLAN YANG validation Using GCU #2190

isabelmsft · 2022-05-31T08:12:05Z

What I did

Added YANG validation to add/remove portchannel using GCU apply patch

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

config/main.py

lgtm-com · 2022-06-01T06:33:20Z

This pull request introduces 1 alert when merging d4ab077 into 2513da1 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-06-01T22:30:49Z

This pull request introduces 1 alert when merging e4db00c into 2513da1 - view on LGTM.com

new alerts:

1 for Unused import

config/main.py

config/validated_config_db_connector.py

lgtm-com · 2022-06-02T05:07:52Z

This pull request introduces 1 alert when merging 8259894 into 3197f39 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-06-02T06:07:01Z

This pull request introduces 1 alert when merging ac45e07 into 3197f39 - view on LGTM.com

new alerts:

1 for Unused import

config/main.py

lgtm-com · 2022-06-03T00:31:28Z

This pull request introduces 1 alert when merging 6bb9189 into 3197f39 - view on LGTM.com

new alerts:

1 for Unused import

config/main.py

lgtm-com · 2022-06-03T06:40:04Z

This pull request introduces 1 alert when merging 6b6feda into 3197f39 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-06-19T23:44:22Z

This pull request introduces 1 alert when merging 98888f4 into 9f2607d - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-06-20T15:22:47Z

This pull request introduces 1 alert when merging d9c069e into 248ddd5 - view on LGTM.com

new alerts:

1 for 'import *' may pollute namespace

lgtm-com · 2022-06-20T17:06:51Z

This pull request introduces 1 alert when merging f0b7fb5 into 248ddd5 - view on LGTM.com

new alerts:

1 for 'import *' may pollute namespace

config/main.py

qiluo-msft · 2022-06-22T20:23:09Z

config/main.py


-    db = ctx.obj['db']
+    db = validate(ctx.obj['db'], error_map, ctx) 


validate

revert this part. #Closed

config/validated_config_db_connector.py

lgtm-com · 2022-07-09T05:30:09Z

This pull request introduces 1 alert when merging 74e8431 into 28926b0 - view on LGTM.com

new alerts:

1 for Unused import

config/validated_config_db_connector.py

qiluo-msft · 2022-07-27T01:31:08Z

config/validated_config_db_connector.py

+
+from generic_config_updater.generic_updater import GenericUpdater, ConfigFormat
+
+def ValidatedConfigDBConnector(config_db_connector):


As we discussed on design, we need to check global disable/enable option. So suggest add the check in this function. #Closed

Sorry I did not mean fallback_adhoc_validation. I mean yang_config_validation you added in ConfigDB. You may check @wen587 PR https://github.com/sonic-net/sonic-buildimage/pull/11715/files

fallback_adhoc_validation should be independent with ValidatedConfigDBConnector. We have use cases like

True, True

True, False

False, True

False, False
So just remove this parameter in this class.

Still applicable.

I changed to make fallback_adhoc_validation independent of ValidatedConfigDBConnector. In ValidatedConfigDBConnector, we use yang_config_enabled

lgtm-com · 2022-08-02T07:37:34Z

This pull request introduces 5 alerts when merging e01c295 into 92b889b - view on LGTM.com

new alerts:

5 for Wrong number of arguments in a call

linux-foundation-easycla · 2022-08-03T18:16:00Z

The committers listed above are authorized under a signed CLA.

✅ login: isabelmsft (f338049)

config/main.py

qiluo-msft · 2022-08-12T23:18:55Z

config/main.py

-                .format(loopback_name, CFG_LOOPBACK_PREFIX, CFG_LOOPBACK_NO))
-
+    config_db = ValidatedConfigDBConnector(ctx.obj['db'], ADHOC_VALIDATION)
+
    lo_config_db = config_db.get_table('LOOPBACK_INTERFACE')


lo_config_db = config_db.get_table('LOOPBACK_INTERFACE')

This line is moved. However you can keep it at original place, right? #Closed

lo_config_db is used with and without ADHOC_VALIDATION, so I moved the definition to before ADHOC_VALIDATION

config/vlan.py

lgtm-com · 2022-09-09T00:46:44Z

This pull request introduces 1 alert when merging 6565224 into bbcdf2e - view on LGTM.com

new alerts:

1 for Syntax error

config/vlan.py

lgtm-com · 2022-09-09T21:23:32Z

This pull request introduces 2 alerts when merging 7a7768a into bbcdf2e - view on LGTM.com

new alerts:

1 for Unused import
1 for Wrong number of arguments in a call

lgtm-com · 2022-09-09T21:41:56Z

This pull request introduces 1 alert when merging 96788dc into bbcdf2e - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-09-14T01:50:05Z

This pull request introduces 1 alert when merging 3566cdc into 4d377a6 - view on LGTM.com

new alerts:

1 for Unused import

qiluo-msft · 2022-09-20T21:02:23Z

generic_config_updater/gu_common.py

@@ -16,6 +16,9 @@
 class GenericConfigUpdaterError(Exception):
    pass

+class EmptyTableError(Exception):


Exception

Inherit from ValueError, then you do not need to change its unit test. #Closed

Changed to inherit from ValueError

config/validated_config_db_connector.py

qiluo-msft · 2022-09-21T23:08:47Z

config/validated_config_db_connector.py

+    config_db.connect()
+    try:
+        GenericUpdater().apply_patch(patch=gcu_patch, config_format=config_format, verbose=False, dry_run=False, ignore_non_yang_tables=False, ignore_paths=None)
+    except EmptyTableError:


EmptyTableError

I understand GCU could not delete the last vlan entry in vlan table, because it will lead to an empty vlan table. And GCU is okay to delete the whole vlan table in this case.

Suggest catch the exception, if the original patch is delete one entry, we change the patch to delete the whole table and retry apply_patch. #Closed

Or you can decorate delete_table, and call it instead.

Or

gcu_json_input.append(gcu_json) gcu_json_input.append({ "op": "remove", "path": table })

I decorated delete_table and changed exception handling to call validated_delete_table

lgtm-com · 2022-09-23T00:57:47Z

This pull request introduces 1 alert when merging 1777e61 into 28f6820 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-09-23T01:22:32Z

This pull request introduces 2 alerts when merging 7084ccb into 28f6820 - view on LGTM.com

new alerts:

2 for Unused import

lgtm-com · 2022-09-23T08:30:58Z

This pull request introduces 2 alerts when merging c20651f into 28f6820 - view on LGTM.com

new alerts:

1 for Unused import
1 for Variable defined multiple times

lgtm-com · 2022-09-23T08:58:04Z

This pull request introduces 1 alert when merging 605cd8c into 28f6820 - view on LGTM.com

new alerts:

1 for Unused import

linux-foundation-easycla · 2022-09-23T22:34:27Z

The committers listed above are authorized under a signed CLA.

✅ login: isabelmsft (f3ee6ce)

commit 1efdb89 Author: isl <isl@contoso.com> Date: Fri Sep 23 22:34:09 2022 +0000 mock call to device_info commit d483ad6 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 23 22:20:39 2022 +0000 Uncomment debug code commit 1a3b257 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 23 22:05:06 2022 +0000 specify yang validation within unit test function commit e01f5c8 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 23 21:39:07 2022 +0000 mock yang_enabled commit 605cd8c Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 23 08:47:24 2022 +0000 address LGTM commit c20651f Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 23 08:20:28 2022 +0000 Fix UTs commit 7084ccb Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 23 01:14:35 2022 +0000 fix validated configdb connector commit 1777e61 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 23 00:48:52 2022 +0000 configure adhoc validation to true commit b4c33e2 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 23 00:47:38 2022 +0000 Address PR comments commit d797149 Author: isabelmsft <isabel.li@microsoft.com> Date: Tue Sep 20 06:07:25 2022 +0000 remove print statements commit 29263f3 Author: isabelmsft <isabel.li@microsoft.com> Date: Tue Sep 20 06:05:31 2022 +0000 syntax error commit 793e659 Author: isabelmsft <isabel.li@microsoft.com> Date: Tue Sep 20 05:51:13 2022 +0000 fix spacing commit 076458f Author: isabelmsft <isabel.li@microsoft.com> Date: Tue Sep 20 05:15:32 2022 +0000 add missing loopback unit tests, etc. commit 9b37211 Author: isabelmsft <isabel.li@microsoft.com> Date: Sun Sep 18 09:07:13 2022 +0000 add validated_config_db_connector_test commit 201f005 Author: isabelmsft <isabel.li@microsoft.com> Date: Sun Sep 18 00:16:12 2022 +0000 reset adhoc validation variable in unit test commit dd66886 Author: isabelmsft <isabel.li@microsoft.com> Date: Sat Sep 17 23:28:03 2022 +0000 fix adhoc validation variable commit 273436c Author: isabelmsft <isabel.li@microsoft.com> Date: Sat Sep 17 09:07:12 2022 +0000 fix portchannel test commit cac0f96 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 16 17:09:27 2022 +0000 add missing space commit c52e8cc Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 16 09:33:54 2022 +0000 fix order commit e24f7d8 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 16 08:29:40 2022 +0000 fix empty table test commit 14addea Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 16 08:13:46 2022 +0000 revert portchannel config unit tests commit 219020c Author: isabelmsft <isabel.li@microsoft.com> Date: Thu Sep 15 20:03:09 2022 +0000 remove unused import commit 5bc3918 Author: isabelmsft <isabel.li@microsoft.com> Date: Thu Sep 15 20:01:29 2022 +0000 fix vlan commit 3566cdc Author: isabelmsft <isabel.li@microsoft.com> Date: Wed Sep 14 01:39:21 2022 +0000 add import jsonpatch commit 96788dc Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 9 21:33:30 2022 +0000 save mod_entry for future PR commit 7a7768a Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 9 21:15:32 2022 +0000 move comment commit 6565224 Merge: ed39006 7546b7c Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 9 00:35:38 2022 +0000 resolve merge conflict commit ed39006 Merge: f338049 bbcdf2e Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 9 00:34:16 2022 +0000 merge commit 7546b7c Merge: f338049 bbcdf2e Author: isabelmsft <67024108+isabelmsft@users.noreply.github.com> Date: Thu Sep 8 17:32:23 2022 -0700 Merge branch 'master' into yang_portchannel_gcu_poc_2 commit f338049 Author: isabelmsft <isabel.li@microsoft.com> Date: Wed Sep 7 19:53:31 2022 +0000 Squashed commit of the following: commit 3ab82c1 Author: isabelmsft <isabel.li@microsoft.com> Date: Wed Sep 7 18:33:46 2022 +0000 add VLAN_MEMBER case commit 74b22e5 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 2 04:28:35 2022 +0000 fix typo, syntax commit e888493 Author: isabelmsft <isabel.li@microsoft.com> Date: Fri Sep 2 03:52:21 2022 +0000 remove remaining mod_entry reference commit dee4a70 Author: isabelmsft <isabel.li@microsoft.com> Date: Tue Aug 23 08:36:29 2022 +0000 set ADHOC_VALIDATION to True by default commit 09a2ec9 Author: isabelmsft <isabel.li@microsoft.com> Date: Tue Aug 23 08:35:59 2022 +0000 remove validated_mod_entry - save for future PR commit 7370198 Merge: 975717b 9f6d79d Author: isabelmsft <isabel.li@microsoft.com> Date: Tue Aug 23 08:34:54 2022 +0000 resolve merge conflict commit 975717b Author: isabelmsft <isabel.li@microsoft.com> Date: Tue Aug 23 08:33:50 2022 +0000 address PR comments commit 4bcd2d2 Author: isabelmsft <isabel.li@microsoft.com> Date: Wed Aug 10 23:18:43 2022 +0000 re-add removed adhoc validation commit 9f6d79d Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Wed Aug 10 23:18:43 2022 +0000 re-add removed adhoc validation commit 405dd9b Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Fri Aug 5 00:02:44 2022 +0000 Add note for missing constraints in YANG model commit b5b15bb Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Wed Aug 3 18:15:45 2022 +0000 address PR comment commit 443b2c3 Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue Aug 2 08:35:00 2022 +0000 fix decorator commit e01c295 Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue Aug 2 07:29:28 2022 +0000 vlan add remove commit 8829d96 Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue Jul 19 09:27:19 2022 +0000 add loopback interfaces config case commit eacc138 Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Sat Jul 9 05:51:58 2022 +0000 remove unused import commit 74e8431 Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Sat Jul 9 05:22:03 2022 +0000 small fixes commit a40c351 Author: Ubuntu <isl@isl-dev-9.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Sat Jul 9 05:17:50 2022 +0000 fix portchannel unit tests, update decorator name commit 3c69396 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue Jun 28 18:11:47 2022 +0000 adjust error handling commit dd2e2fd Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue Jun 21 00:28:21 2022 +0000 Address LGTM, formatting fixes commit f0b7fb5 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Mon Jun 20 16:36:05 2022 +0000 Add error specific error handling commit d9c069e Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Mon Jun 20 15:10:10 2022 +0000 fix imports commit 98888f4 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Sun Jun 19 23:35:55 2022 +0000 keep one ConfigDBConnector instance commit e9f0baf Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue Jun 14 17:46:00 2022 +0000 re add comment commit 1df71b3 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue Jun 14 16:14:43 2022 +0000 Revert to just db.set_entry() commit 57ab896 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Sat Jun 4 03:53:59 2022 +0000 remove portchannel member changes commit 42051c9 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Fri Jun 3 22:20:15 2022 +0000 Fix unit tests, LGTM commit 6b6feda Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Fri Jun 3 06:31:08 2022 +0000 separate db and validated_db commit 6bb9189 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Fri Jun 3 00:22:30 2022 +0000 simplify wrapper commit ac45e07 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Thu Jun 2 05:56:57 2022 +0000 fix quotes commit 8259894 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Thu Jun 2 04:58:48 2022 +0000 change to decorated commit e4db00c Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Wed Jun 1 22:21:09 2022 +0000 Keep original method signature commit d4ab077 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Wed Jun 1 06:23:52 2022 +0000 Move GCU to subclass commit 220a605 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue May 31 07:32:29 2022 +0000 remove yvs commit cb9cb94 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue May 31 07:30:33 2022 +0000 portchannel add and remove commit e5d3687 Merge: 95afe70 2513da1 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Mon May 30 20:49:25 2022 +0000 Merge branch 'master' of https://github.com/Azure/sonic-utilities commit 95afe70 Merge: 8909517 2f53bd4 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue May 24 21:53:43 2022 +0000 Merge branch 'master' of https://github.com/Azure/sonic-utilities commit 8909517 Author: Ubuntu <isl@isl-dev-6.gccxvha3jmperpu0bogtupfduf.jx.internal.cloudapp.net> Date: Tue May 10 10:55:19 2022 +0000 Add portchannel YANG validation

isabelmsft requested a review from qiluo-msft May 31, 2022 18:29

qiluo-msft reviewed May 31, 2022

View reviewed changes

config/main.py Show resolved Hide resolved

isabelmsft requested a review from wen587 June 1, 2022 06:35

qiluo-msft reviewed Jun 1, 2022

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Jun 1, 2022

View reviewed changes

config/main.py Show resolved Hide resolved

qiluo-msft reviewed Jun 1, 2022

View reviewed changes

config/validated_config_db_connector.py Outdated Show resolved Hide resolved

qiluo-msft requested a review from liuh-80 June 2, 2022 19:01

qiluo-msft reviewed Jun 2, 2022

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Jun 2, 2022

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Jun 3, 2022

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Jun 22, 2022

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Jun 22, 2022

View reviewed changes

config/validated_config_db_connector.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Jun 22, 2022

View reviewed changes

config/validated_config_db_connector.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Jul 19, 2022

View reviewed changes

config/validated_config_db_connector.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Jul 19, 2022

View reviewed changes

config/validated_config_db_connector.py Show resolved Hide resolved

qiluo-msft reviewed Jul 19, 2022

View reviewed changes

config/validated_config_db_connector.py Show resolved Hide resolved

isabelmsft changed the title ~~[POC] YANG validation for ConfigDB Updates: portchannel add/remove YANG validation Using GCU~~ [POC] YANG validation for ConfigDB Updates: portchannel add/remove, loopback interface YANG validation Using GCU Jul 20, 2022

qiluo-msft reviewed Jul 27, 2022

View reviewed changes

qiluo-msft reviewed Aug 12, 2022

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Aug 12, 2022

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Aug 12, 2022

View reviewed changes

config/vlan.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Aug 12, 2022

View reviewed changes

config/vlan.py Show resolved Hide resolved

isabelmsft changed the title ~~[POC] YANG validation for ConfigDB Updates: portchannel add/remove, loopback interface YANG validation Using GCU~~ YANG validation for ConfigDB Updates: portchannel add/remove, loopback interface YANG validation Using GCU Aug 12, 2022

isabelmsft force-pushed the yang_portchannel_gcu_poc_2 branch from 3ab82c1 to f338049 Compare September 7, 2022 19:54

qiluo-msft reviewed Sep 9, 2022

View reviewed changes

config/vlan.py Outdated Show resolved Hide resolved

isabelmsft marked this pull request as ready for review September 16, 2022 09:24

isabelmsft changed the title ~~YANG validation for ConfigDB Updates: portchannel add/remove, loopback interface YANG validation Using GCU~~ YANG validation for ConfigDB Updates: portchannel add/remove, loopback interface, VLAN YANG validation Using GCU Sep 20, 2022

qiluo-msft reviewed Sep 20, 2022

View reviewed changes

config/validated_config_db_connector.py Outdated Show resolved Hide resolved

qiluo-msft reviewed Sep 21, 2022

View reviewed changes

isabelmsft force-pushed the yang_portchannel_gcu_poc_2 branch from 1efdb89 to f3ee6ce Compare September 23, 2022 22:52

qiluo-msft approved these changes Sep 23, 2022

View reviewed changes

isabelmsft merged commit 123504a into sonic-net:master Sep 24, 2022


		db = ctx.obj['db']
		db = validate(ctx.obj['db'], error_map, ctx)


		from generic_config_updater.generic_updater import GenericUpdater, ConfigFormat

		def ValidatedConfigDBConnector(config_db_connector):

YANG validation for ConfigDB Updates: portchannel add/remove, loopback interface, VLAN YANG validation Using GCU #2190

YANG validation for ConfigDB Updates: portchannel add/remove, loopback interface, VLAN YANG validation Using GCU #2190

Conversation

isabelmsft commented May 31, 2022

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

lgtm-com bot commented Jun 1, 2022

lgtm-com bot commented Jun 1, 2022

lgtm-com bot commented Jun 2, 2022

lgtm-com bot commented Jun 2, 2022

lgtm-com bot commented Jun 3, 2022

lgtm-com bot commented Jun 3, 2022

lgtm-com bot commented Jun 19, 2022

lgtm-com bot commented Jun 20, 2022

lgtm-com bot commented Jun 20, 2022

qiluo-msft Jun 22, 2022 • edited Loading

Choose a reason for hiding this comment

lgtm-com bot commented Jul 9, 2022

qiluo-msft Jul 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Aug 2, 2022

linux-foundation-easycla bot commented Aug 3, 2022 • edited Loading

qiluo-msft Aug 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Sep 9, 2022

lgtm-com bot commented Sep 9, 2022

lgtm-com bot commented Sep 9, 2022

lgtm-com bot commented Sep 14, 2022

qiluo-msft Sep 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qiluo-msft Sep 21, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Sep 23, 2022

linux-foundation-easycla bot commented Sep 23, 2022 • edited Loading

qiluo-msft Jun 22, 2022 •

edited

Loading

qiluo-msft Jul 27, 2022 •

edited

Loading

linux-foundation-easycla bot commented Aug 3, 2022 •

edited

Loading

qiluo-msft Aug 12, 2022 •

edited

Loading

qiluo-msft Sep 20, 2022 •

edited

Loading

qiluo-msft Sep 21, 2022 •

edited

Loading

linux-foundation-easycla bot commented Sep 23, 2022 •

edited

Loading