-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IP interface loopback action #2192
Merged
liat-grozovik
merged 9 commits into
sonic-net:master
from
liorghub:ip_interface_loopback
Jul 7, 2022
Merged
Add support for IP interface loopback action #2192
liat-grozovik
merged 9 commits into
sonic-net:master
from
liorghub:ip_interface_loopback
Jul 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
previously approved these changes
Jun 13, 2022
…pdate DB with user changes
Remove redundant check of interface existence config DB.
@dgsudharsan, @prsunny could you please review following the review comments handling? |
…n CLI command syntax
… changes in CLI command syntax
prsunny
approved these changes
Jun 29, 2022
dgsudharsan
approved these changes
Jun 29, 2022
Can you please update the description of the PR to reflect the newly updated config command syntax? |
@dgsudharsan |
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Jul 7, 2022
Update sonic-utilities submodule pointer to include the following: * [show] add new CLI to show tunnel route objects ([sonic-net#2255](sonic-net/sonic-utilities#2255)) * Add support for IP interface loopback action ([sonic-net#2192](sonic-net/sonic-utilities#2192)) * Update load minigraph to load backend acl ([sonic-net#2236](sonic-net/sonic-utilities#2236)) * show linkmgrd status in ([sonic-net#2254](sonic-net/sonic-utilities#2254)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Jul 7, 2022
- What I did Add support for IP interface loopback action. - How I did it Add new commands and handilig, Update the commad reference guide to incldue the new show command - How to verify it New CLI unittests were added. Previous command output (if the output of a command-line utility has changed) None New command output (if the output of a command-line utility has changed) root@sonic:~# config interface ip loopback-action Ethernet0 drop root@sonic:~# show ip interfaces loopback-action Interface Action ------------ ---------- Ethernet232 drop Vlan100 forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add support for IP interface loopback action.
How I did it
Add new commands and handilig, Update the commad reference guide to incldue the new show command
How to verify it
New CLI unittests were added.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)