[counters] skip showing counters that are not enabled #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
neethajohn
approved these changes
Jun 8, 2022
This was referenced Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Skip counters that are not enabled.
How to verify it
With change sonic-net/sonic-swss#2143, following commands will cause exception:
admin@vlab-01:~$ show priority-group persistent-watermark headroom
Traceback (most recent call last):
File "/usr/local/bin/watermarkstat", line 315, in
main()
File "/usr/local/bin/watermarkstat", line 310, in main
watermarkstat.print_all_stat(table_prefix, args.type)
File "/usr/local/bin/watermarkstat", line 261, in print_all_stat
data = self.get_counters(table_prefix,
File "/usr/local/bin/watermarkstat", line 237, in get_counters
elif fields[pos] != STATUS_NA:
IndexError: list index out of range
With the change:
admin@vlab-01:~$ show priority-group persistent-watermark headroom
Ingress headroom per PG:
Port
Ethernet0
Ethernet4
Ethernet8
Ethernet12
Ethernet16
... ...
Signed-off-by: Ying Xie ying.xie@microsoft.com