-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202012] [cherry-pick] Update db_migrator to support PORT_QOS_MAP|global
#2215
Merged
bingwang-ms
merged 7 commits into
sonic-net:202012
from
bingwang-ms:migrate_port_qos_map_global_202012
Jul 26, 2022
Merged
[202012] [cherry-pick] Update db_migrator to support PORT_QOS_MAP|global
#2215
bingwang-ms
merged 7 commits into
sonic-net:202012
from
bingwang-ms:migrate_port_qos_map_global_202012
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
6 tasks
Comment left on the original PR #2205 is also applicable here. |
neethajohn
reviewed
Jul 14, 2022
Thanks. I address the issue by checking the ASIC type. The table is only generated on one platform now. Also a test scenario is added to cover that. |
neethajohn
approved these changes
Jul 15, 2022
stephenxs
approved these changes
Jul 21, 2022
neethajohn
reviewed
Jul 21, 2022
prsunny
approved these changes
Jul 26, 2022
vaibhavhd
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 2, 2022
…11558) To include latest warmboot fixes: [202012] [cherry-pick] Update db_migrator to support `PORT_QOS_MAP|gl (sonic-net/sonic-utilities/pull/2215) [202012] Migrate missed config on cross branch warm upgrade to 202012 (sonic-net/sonic-utilities#2277) [202012] Add db_migrator_constants.py script to setup.py (sonic-net/sonic-utilities#2287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is to cherry-pick #2205 into
202012
branch after resolving conflicts.This PR is to update the
db_migrator
to support generation ofPORT_QOS_MAP|global
.After PR sonic-net/sonic-buildimage#10565, there will be two DSCP_TO_TC_MAP
To address the issue, an entry
PORT_QOS_MAP|global
will be added intoconfig_db
To handle the upgrade from older image,
db_migrator
is updated to generate the entry.There is no way to check if
PORT_QOS_MAP|global
is supported, so the migration is ran on all platforms. There is check insonic-swss
to check the switch capability code, so it will not cause issue.How I did it
Update
db_migrator
to add a common migration step.How to verify it
Verified by vstest
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)