[intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
changed the title
dgsudharsan
suggested changes
Jun 24, 2022
prgeor
reviewed
Jun 27, 2022
dgsudharsan
suggested changes
Jun 28, 2022
dgsudharsan
suggested changes
Jun 28, 2022
Signed-off-by: Stephen Sun <stephens@nvidia.com>
dgsudharsan
approved these changes
Jul 1, 2022
|
@prgeor could you please help to review? |
prgeor
approved these changes
Jul 28, 2022
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
Update sonic-utilities submodule pointer to include the following: * Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295)) * Fix issues for sonic_installer upgrade-docker and sonic_installer rollback-docker ([sonic-net#2278](sonic-net/sonic-utilities#2278)) * [crm] add checking for CRM interval range ([sonic-net#2293](sonic-net/sonic-utilities#2293)) * Fix the issue that sonic_platform is not installed on vs image ([sonic-net#2300](sonic-net/sonic-utilities#2300)) * Add FEC correctable and uncorrectable port stats ([sonic-net#2027](sonic-net/sonic-utilities#2027)) * Add CLI to configure YANG config validation ([sonic-net#2147](sonic-net/sonic-utilities#2147)) * Add override testcase to verify removal ([sonic-net#2288](sonic-net/sonic-utilities#2288)) * Fix version in db_migrator for ([sonic-net#2289](sonic-net/sonic-utilities#2289)) * [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223)) * Transfer organization from Azure to sonic-net ([sonic-net#2284](sonic-net/sonic-utilities#2284)) * [watermarkstat] Fix CLI script for unconfigured PG counters ([sonic-net#2239](sonic-net/sonic-utilities#2239)) * Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 11, 2022
…fore configuring it to CONFIG_DB (#2223) * Support FEC capability Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix review comments Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust dump table test according to STATE_DB change Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add missing field in the test Signed-off-by: Stephen Sun <stephens@nvidia.com> * Do not change dump state test Signed-off-by: Stephen Sun <stephens@nvidia.com>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 12, 2022
Update sonic-utilities submodule pointer to include the following: * Fix test failure in dump table test in 202205 ([sonic-net#2307](sonic-net/sonic-utilities#2307)) * Convert IPv6 addresses to lowercase in apply-patch ([sonic-net#2299](sonic-net/sonic-utilities#2299)) * [config][muxcable] add support to enable/disable ycable telemetry ([sonic-net#2297](sonic-net/sonic-utilities#2297)) * Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295)) * [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223)) * Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * Support to enable fips for the command sonic_installer (sonic-net#2154) ([sonic-net#2303](sonic-net/sonic-utilities#2303)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…fore configuring it to CONFIG_DB (sonic-net#2223) * Support FEC capability Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix review comments Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust dump table test according to STATE_DB change Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add missing field in the test Signed-off-by: Stephen Sun <stephens@nvidia.com> * Do not change dump state test Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB
It depends on sonic-net/sonic-swss#2333
Signed-off-by: Stephen Sun stephens@nvidia.com
How I did it
The supported FEC mode is exposed to
STATE_DB.PORT_TABLE|<port>.supported_fecsby orchagentCLI checks whether the FEC mode to be set is in the
supported_fecslist before configuring it to CONFIG_DB.Specifically, in case the vendor SAI doesn’t support fetching supported FEC mode,
N/Ashould be exposed. In this case, any FEC model should be supported.How to verify it
Run mock test and manual test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)