Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-front-panel ports in is_rj45_port #2327

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Handle non-front-panel ports in is_rj45_port #2327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6c403f
Handle non-front-panel ports in is_rj45_port
stephenxs Aug 23, 2022
d9aaf74
Use APIs in sonic_platform_base
stephenxs Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utilities_common/platform_sfputil_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def is_rj45_port(port_name):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bit of debugging and see that the below code section

        if not platform_porttab_mapping_read:
            platform_sfputil_read_porttab_mappings()

is actually creating this logs which @mlok-nokia was pointing out

Aug 25 05:50:23.693785 str2--lc1-1 ERR Chassis: :- initializeGlobalConfig: SonicDBConfig Global config is already initialized

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I'll check it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@judyjoseph if possible, can you share more details, like call stack? I don't have a multi-chassis testbed, it will be time-consuming for me to find it out. thank you.

port_type = None
try:
physical_port = logical_port_name_to_physical_port_list(port_name)
physical_port = platform_sfputil.logical_port_name_to_physical_port_list(port_name)
if physical_port:
port_type = platform_chassis.get_port_or_cage_type(physical_port[0])
except Exception as e:
Expand Down