Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing commands for release 202111 in the command reference #2352

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Added missing commands for release 202111 in the command reference #2352

merged 1 commit into from
Sep 7, 2022

Conversation

kannankvs
Copy link
Collaborator

Signed-off-by: kannankvs kannan_kvs@dell.com

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

This is in continuation to the PR2134 As the mentioned PR had incorrect commits, closed it and raised this PR. The comments given in previous PR is mentioned below.

**@wen587 Hi, need to mention that GCU is experimental in 202111 and may not function well.
GCU is fully supporte in 202205.

Addressed**

**@wen587 Hi, it seems the total documentation was removed fully and then added back, which make reviewer cannot check the file diff from here https://github.com/sonic-net/sonic-utilities/pull/2314/files.
Can we keep the original format and just add what is missing? That should be easier to compare the diff from the website.

While updating the CLI file for 202111 branch, the file diff is seen for whole of the file. While the merge is for master, then only the diff of changes is shown. Kindly suggest.**

Addressed the above 2 comments in this PR.

Signed-off-by: kannankvs <kannan_kvs@dell.com>
@kannankvs kannankvs changed the title addressed review comments Added missing commands for release 202111 in the command reference Sep 6, 2022
@xinliu-seattle xinliu-seattle merged commit 77bf177 into sonic-net:202111 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants