[generate_dump]: Enhance show techsupport for cisco-8000 platform #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geert Vlaemynck <gvlaemyn@cisco.com>
|
@gvlaemyn please add unit test. |
|
@yxieca can you merge this PR in master? Geert will tackle the unit-test via the separate issue. |
mdanish-kh
pushed a commit
to hamnarauf/sonic-utilities
that referenced
this pull request
Oct 22, 2022
…nic-net#2403) Signed-off-by: Geert Vlaemynck <gvlaemyn@cisco.com> Signed-off-by: Geert Vlaemynck <gvlaemyn@cisco.com>
|
@yxieca Is this PR not merged in 202205 yet? |
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…nic-net#2403) Signed-off-by: Geert Vlaemynck <gvlaemyn@cisco.com> Signed-off-by: Geert Vlaemynck <gvlaemyn@cisco.com>
@alpeshspatel , No. I cannot cherry-pick this change cleanly. Can you or @gvlaemyn create an PR for 202205 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Geert Vlaemynck gvlaemyn@cisco.com
What I did
Added cisco-8000 specific platform information to "show techsupport" tarfile
How I did it
Added collect_cisco_8000 function to scripts/generate_dump which filters out the wanted files from /usr/share/sonic/device/${platform} and saves them in the techsupport tarfile under sai subdirectory
How to verify it
Run "show techsupport" and grep sai in the generated techsupport tarfile
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)