Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Port Modes and VLAN CLI Enhancement #2419

Merged
merged 72 commits into from
Aug 24, 2023
Merged

Switch Port Modes and VLAN CLI Enhancement #2419

merged 72 commits into from
Aug 24, 2023

Commits on Oct 1, 2022

  1. Modification of Vlan.py and creation of switchport.py

    - What I did
    
    Modified config/vlan.py to add new commands with multiple and range
    options
    
    Creation of config/switchport.py which will deal with default Vlan1
    
    Modified the show interface command so it will show the status of port
    being access or trunk. Before it did not show about access mode only
    trunk.
    
    Modified the Command-Reference.md file to add new commands in it with
    usage and examples
    
    Added new utility functions in utilities_common/cli.py for new Vlan.py
    and switchport.py commands
    
    - How I did
    
    Added new commands and modified the existing commands in config/vlan.py
    for example to accept multiple vids and range of vids in add|del vlan
    and add|del vlan member as well as except flag in vlan member command
    
    Creation of config/switchport.py file to add commands which will deal
    only with Default Vlan1 which was unable to be defined or assigned in
    SONiC before
    
    New utility functions in utilities_common/cli.py
    
    changes in scripts/intfutil. Modified the existing function and now it
    will display if an interface is in access mode or trunk mode with routed
    mode.
    
    - How to verify it
    
    New commands have been added in Command-Reference.md
    All the syntax and examples have been added there and they can be
    verified by running the specific command
    
    Signed-off-by: Muhammad Umar Asad <umarasad20@gmail.com> < xFlow
    Research Inc. >
    MuhammadUmarAsad committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    330b101 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Configuration menu
    Copy the full SHA
    d4ba163 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Configuration menu
    Copy the full SHA
    0ddb795 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b3ac13 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Modified switchport.py functionality removing default Vlan from it

    Modified './config/vlan.py' and added switchport mode checks in it as well as other small checks
    
    Modified './scripts/intfutil/' to show correct port mode with access option for 'show interfaces status' command and its subfunctions
    
    Added utilities functions in './utilities_common/cli.py' for './config/switchport.py'
    
    Updated mocktables according to the tests and addded 'Mode' attribute in PORT table as well as 'Vlan' to 'Mode' in intfutil and multi_asic tests expected outputs of vlan_test.py
    MuhammadUmarAsad committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    930630c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa5d756 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Modification in vlan.py and switchport.py

    Fixed config_db_vlan_port_keys_get() in intfutil to show correct port mode
    
    updated test cases in '/tests/vlan_test.py' for enhanced vlan commands
    and new switchport commands which are used with vlan member commands
    
    Signed-off-by: Muhammad Umar Asad <umarasad20@gmail.com> xFlow Research
    Inc.
    MuhammadUmarAsad committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    02b1e8a View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Added support for mode attribute in IP config commands and updated the

    related testcase
    
    removed the fucntionality for checking vlan status to assign IP Address
    It will now assign IP Address if the port is in 'routed' mode else it won't assign
    
    Signed-off-by: Muhammad Umar Asad <umar.asad@xflowresearch.com> xFlow Research Inc.
    MuhammadUmarAsad committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    cd13da3 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Added switchport mode support for PORTCHANNEL

    updated the Command-Reference.md for PortChannel switchport commands as
    well
    Updated the test cases for Portchnnel for switchport
    MuhammadUmarAsad committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    519324d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ca0d24 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Configuration menu
    Copy the full SHA
    5fea7b8 View commit details
    Browse the repository at this point in the history
  2. updated the merge conflicts

    updated the merger conflicts in the multi_asic_intfutil_test.py
    MuhammadUmarAsad committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2fd4c09 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Resolved Merge Conflicts with #2669

    The vlan.py and other files were modified to add DHCPv4 and DHCPv6 relay
    tables so the PR was needed to be updated
    MuhammadUmarAsad committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    22888f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99609dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4176fec View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Configuration menu
    Copy the full SHA
    b4e46db View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Configuration menu
    Copy the full SHA
    6ea6025 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a007d20 View commit details
    Browse the repository at this point in the history
  3. fixing db_migrator

    MuhammadUmarAsad committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    d77508f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d64ddd6 View commit details
    Browse the repository at this point in the history
  5. db_migrator

    MuhammadUmarAsad committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    5a18655 View commit details
    Browse the repository at this point in the history
  6. changes in db migrator for switchport

    if vlan member table empty, do not migrate any settings
    MuhammadUmarAsad committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    499b6d5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    63e28aa View commit details
    Browse the repository at this point in the history
  8. updated migrate_config_db_port_table_for_switchport_mode to migrate_c…

    …onfig_db_port_portchannel_table_for_switchport_mode and added support for portchannel
    MuhammadUmarAsad committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    b4197b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Configuration menu
    Copy the full SHA
    0df0f34 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Configuration menu
    Copy the full SHA
    8bc5493 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    046fc2e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92f8a2c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dd4828a View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Configuration menu
    Copy the full SHA
    478a3a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c5a1ea1 View commit details
    Browse the repository at this point in the history
  3. Revert "db_migrator test cases"

    This reverts commit c5a1ea1.
    MuhammadUmarAsad committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    9547b95 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f7bc359 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d856425 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6861d63 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1458610 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ae00297 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5ccc73b View commit details
    Browse the repository at this point in the history
  10. db_migrator test

    MuhammadUmarAsad committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    ddabf32 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9411196 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c3fab6d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    da65f41 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Configuration menu
    Copy the full SHA
    4c03ff1 View commit details
    Browse the repository at this point in the history
  2. updated migrate_config_db_switchport_mode in db_migrator and updated …

    …the expected output for test case
    MuhammadUmarAsad committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    e347a61 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Configuration menu
    Copy the full SHA
    43d7b05 View commit details
    Browse the repository at this point in the history
  2. updated the db_migrator and vlan.py for merge conflicts and removed p…

    …rint prompts while adding or deleting vlans or assigning vlan members will only show prompt for errors
    MuhammadUmarAsad committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    55dbfb3 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. updated vlan test cases. Removed Assertion of vlan addition|deletion …

    …print statements wrt to changes in code
    MuhammadUmarAsad committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f4b130c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e980471 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1836cd8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7998123 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    485b4c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2273103 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba7b72d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    57f1c99 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    70cbfe5 View commit details
    Browse the repository at this point in the history
  6. indentation fix

    Signed-off-by: RoRonoa <umarasad20@gmail.com>
    MuhammadUmarAsad committed May 9, 2023
    Configuration menu
    Copy the full SHA
    ebc14ca View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Configuration menu
    Copy the full SHA
    5b1063c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Configuration menu
    Copy the full SHA
    3faca88 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    7177585 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2672a99 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f87a7e7 View commit details
    Browse the repository at this point in the history
  4. running pipelines

    MuhammadUmarAsad committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    7ccb817 View commit details
    Browse the repository at this point in the history
  5. added pass statement instead of error when running switchport mode co…

    …mmand for routed when it is already in routed mode
    MuhammadUmarAsad committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    43a5e17 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Configuration menu
    Copy the full SHA
    76b4f81 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    a70fd53 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. running pipelines

    MuhammadUmarAsad committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    cba8e2e View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Configuration menu
    Copy the full SHA
    dd11b3c View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    300b353 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    95912ba View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. spacing

    MuhammadUmarAsad committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f63f960 View commit details
    Browse the repository at this point in the history
  2. pipeline trigger

    MuhammadUmarAsad committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    7b7fd96 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. pipeline trigger

    MuhammadUmarAsad committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6d67b53 View commit details
    Browse the repository at this point in the history